-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support string comparison for jwt-role-claim-key #3813
Conversation
@taimoorzaeem How about some docs for this feature? I think we should:
|
60d92f6
to
31933e8
Compare
31933e8
to
4d1106e
Compare
Codecov still complains about some lines, can you try and clear those? |
4d1106e
to
124fc8c
Compare
124fc8c
to
03d3da0
Compare
@steve-chavez I have changed the |
@taimoorzaeem Are those functionally equivalent? |
Yes, absolutely. |
e2d86ae
to
ddfac53
Compare
ddfac53
to
eff8929
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🚀
Fixes #1536.
@steve-chavez Please review.