Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support string comparison for jwt-role-claim-key #3813

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

taimoorzaeem
Copy link
Collaborator

Fixes #1536.

@steve-chavez Please review.

@steve-chavez
Copy link
Member

steve-chavez commented Dec 7, 2024

@taimoorzaeem How about some docs for this feature?

I think we should:

@steve-chavez
Copy link
Member

Codecov still complains about some lines, can you try and clear those?

@taimoorzaeem taimoorzaeem marked this pull request as draft December 11, 2024 16:18
@taimoorzaeem taimoorzaeem marked this pull request as ready for review December 11, 2024 18:59
@taimoorzaeem
Copy link
Collaborator Author

@steve-chavez I have changed the $== operator with ==^. Turns out that the $ character does not work well inside environment variable values which was causing some issues during testing. I could have overlooked this if it wasn't for code-cov not passing enough. Huh, another win for code-cov testing 🚀.

@steve-chavez
Copy link
Member

I have changed the $== operator with ==^

@taimoorzaeem Are those functionally equivalent?

@taimoorzaeem
Copy link
Collaborator Author

@taimoorzaeem Are those functionally equivalent?

Yes, absolutely.

Copy link
Member

@steve-chavez steve-chavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

@steve-chavez steve-chavez merged commit af6b79d into PostgREST:main Dec 12, 2024
25 checks passed
@taimoorzaeem taimoorzaeem deleted the jwt-iter/issue1536 branch December 13, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

jwt: iterate over roles
2 participants