Skip to content
This repository has been archived by the owner on Feb 3, 2021. It is now read-only.

instalation on subdirectory support added 1st stage #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

callingmybluff
Copy link

@callingmybluff callingmybluff commented Jun 25, 2018

Pull Request Summary

This is the first stage into implementing the feature #90.
This step replaces most static usage of root directory to an environment variable APP_LOCATION

However, with this PR, the feature is not done, and there are two issue I encountered and could not solve so far:

  • When a url has a redirect, like login: /sub/admin/login?redirect=%2Fadmin will direct into /admin

  • resources from the upload directory "uploads" are links in the page to /uploads/... instead of /sub/uploads/....


All code contributions are subject to the terms of the Contributor License Agreement described in CONTRIBUTING.md.

@claviska
Copy link
Member

Thanks for submitting.

When a url has a redirect, like login: /sub/admin/login?redirect=%2Fadmin will direct into /admin

This may point you in the right direction.

resources from the upload directory "uploads" are links in the page to /uploads/... instead of /sub/uploads/....

I think the problem here is that the editor generates root-relative URLs. I'm not sure what side effects we'll incur by changing it to relative. It's worth experimenting with at least.

@callingmybluff
Copy link
Author

callingmybluff commented Jun 26, 2018

I managed to do the redirect easily, but the images thing is a bit tough. I managed to change images in display while input, but that resulted in problems (storing wrong url probably?)

@kylechine
Copy link

I don't know if this is annoying. But I just want to say thank you, guys.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants