Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Toggledisplay broken on latest version and 1.19 #224

Closed
pacificminer opened this issue Aug 14, 2022 · 4 comments
Closed

[BUG] Toggledisplay broken on latest version and 1.19 #224

pacificminer opened this issue Aug 14, 2022 · 4 comments
Labels
wontfix This will not be worked on

Comments

@pacificminer
Copy link

Description

After updating my server to 1.19 and QuickShop to the latest version: 5.1.0.9, the /qs toggledisplay now no longer works as intended. If players wish to hide the item hologram, and type /qs toggledisplay, it is disabled for about a second before the item hologram returns. This effectively makes it impossible to hide the shop's item hologram.

Steps to reproduce

Create a Shop and do /qs toggledisplay

Expected Behaviour

The item shouldn't display when toggled

Screenshots

N/A

/qs paste URL

Additional Context

No response

@sandtechnology
Copy link

What about your /qs paste URL? Without this we can't do anything

@sandtechnology
Copy link

Anyway, just check the code and found this may cause this, but still, without /qs paste URL, we could not know what environment you are, you can test it with this build: https://ci.codemc.io/job/PotatoCraft-Studio/job/QuickShop-Reremake-SNAPSHOT/2393/artifact/target/QuickShop-5.1.0.10-SNAPSHOT.jar

@pacificminer
Copy link
Author

Anyway, just check the code and found this may cause this, but still, without /qs paste URL, we could not know what environment you are, you can test it with this build: https://ci.codemc.io/job/PotatoCraft-Studio/job/QuickShop-Reremake-SNAPSHOT/2393/artifact/target/QuickShop-5.1.0.10-SNAPSHOT.jar

Works again. Thank you

@stale
Copy link

stale bot commented Oct 14, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 14, 2022
@stale stale bot closed this as completed Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants