[BUG] MCMMO Fast digging II potions showing as fast digging I #305
Comments
In the paste I see it actually is fast digging I, what about the information shows in the tooltip of this item? |
|
The tooltip is showing haste 2, I have recorded a video showing the problem: https://www.youtube.com/watch?v=GmDovZ2iTR0 |
sandtechnology
added a commit
that referenced
this issue
Feb 16, 2023
|
Sorry for the late reply, this snapshot should fix this problem, you can try that out: https://ci.codemc.io/job/PotatoCraft-Studio/job/QuickShop-Reremake-SNAPSHOT/2466/artifact/target/QuickShop.jar |
sandtechnology
added a commit
that referenced
this issue
Mar 17, 2023
* PlayerFinder:Disable offline search when offline stash is enabled * Bump to 5.1.1.3 * Add progress report and try-catch block for offline player caching * Add error counting for caching offline player * Create crowdin ota workflow * Let workflow runs when translation PR merged * Use crowdin ids in secrets * Add okhttp shutdown logic on plugin disabling * Say hello to CrowdinOTA again Change crowdin requesting behavior to use timestamp querying files and not caching when querying manifest * New Crowdin translations by Github Action (#288) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * Fix test * Fix test again * Fix messed okhttp cache folder * Temporary disable custom_languages field for wrong format See Ghost-chu/CrowdinCopyDeploy#1 * Fix enderchest shop not working * Refactor PlayerFinder and solve lag issue for real * Fix unwanted change to registerCustomCommands * PlayerFinder: use toLowerCase(Locale.ROOT) when updating * PlayerFinder: fix a bug which returning null for name2uuid * Disable the support of reloading DatabaseManager * Fix bug for bypassing item stacking option * Add user agent to http query * Fix a bug for got NPE when eco plugin not installed * Update LandsAPI ABI * Add include-offlineplayer-for-command option * Fix unit test for mojang api * Fix the bug about using static language * Update the doc in config.yml for this fix * #299 Set connectTimeout to 10 seconds * update mcbbs link (#310) * fix wrong update link * update link * update link * Update MCBBS Link * [ShopPurger] Add timeout to prevent crash server * SubCommand_Find: Add finding enchantments on enchanted books (#306) * SubCommand_Find: Add finding enchants on books * Reduce nested if's into singular if statement using && * Combine getBooksEnchantments and listContainsString into single function * Add missed imports --------- Co-authored-by: sandtechnology <20417547+sandtechnology@users.noreply.github.com> * Add manual trigger for crowdin workflow * New Crowdin translations by Github Action (#292) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * #305 Fix wrong potionEffect level showing * Bump skyblock from 2.3.30 to 2.5.0 (#312) Bumps skyblock from 2.3.30 to 2.5.0. --- updated-dependencies: - dependency-name: com.songoda:skyblock dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add listener to handle Spartan compatibility * Add missed soft depends for Spartan * #316 Delete wrong depends on ArmShopBridge * New Crowdin translations by Github Action (#313) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * Refactor PriceLimiter Improve code readability Fix free shop price checking Fix digit checking not working other than shop creation Send detail message to player after price check failed * Fix wrong price in price error message * Add missed comment * Remove GroupManager check No idea why ghost adding this check, groupmanager should work along with QS * Fix maximumDigitsInPrice not working It should have extra # in formatting * Fix broken maximumDigitsInPrice config option and config version * Fix broken coloring * Fix javadoc for isBookEnchantmentsMatched method * Revert "Fix broken coloring" This reverts commit df93077. * Use modified MineDown to fix color issue * Fix price limit message not correct * Fix not calc the real tax in message when selling item (permission) * Add PlayerShopClickEvent and Deprecated ShopClickEvent * Add 1.19.4 support * New Crowdin translations by Github Action (#320) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * Bump GriefPrevention from 16.18 to 16.18.1 (#324) Bumps [GriefPrevention](https://github.com/TechFortress/GriefPrevention) from 16.18 to 16.18.1. - [Release notes](https://github.com/TechFortress/GriefPrevention/releases) - [Commits](GriefPrevention/GriefPrevention@16.18...16.18.1) --- updated-dependencies: - dependency-name: com.github.TechFortress:GriefPrevention dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump SongodaCore from 2.6.16 to 2.6.18 (#303) Bumps SongodaCore from 2.6.16 to 2.6.18. --- updated-dependencies: - dependency-name: com.songoda:SongodaCore dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump LandsAPI from 6.26.18 to 6.28.11 (#314) Bumps [LandsAPI](https://github.com/Angeschossen/LandsAPI) from 6.26.18 to 6.28.11. - [Release notes](https://github.com/Angeschossen/LandsAPI/releases) - [Commits](IncrediblePlugins/LandsAPI@6.26.18...6.28.11) --- updated-dependencies: - dependency-name: com.github.angeschossen:LandsAPI dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump spigot-api from 1.19.3-R0.1-SNAPSHOT to 1.19.4-R0.1-SNAPSHOT (#325) Bumps spigot-api from 1.19.3-R0.1-SNAPSHOT to 1.19.4-R0.1-SNAPSHOT. --- updated-dependencies: - dependency-name: org.spigotmc:spigot-api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump PlotSquared-Core from 6.10.5 to 6.11.1 (#321) Bumps [PlotSquared-Core](https://github.com/IntellectualSites/PlotSquared) from 6.10.5 to 6.11.1. - [Release notes](https://github.com/IntellectualSites/PlotSquared/releases) - [Commits](IntellectualSites/PlotSquared@6.10.5...6.11.1) --- updated-dependencies: - dependency-name: com.plotsquared:PlotSquared-Core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump to 5.1.2.0 * Fix price change log recording wrong new price --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: YuanYuanOwO <81153017+YuanYuanOwO@users.noreply.github.com> Co-authored-by: Efe Kurban <efekurbann@gmail.com> Co-authored-by: Smudge <68658429+smuddgge@users.noreply.github.com> Co-authored-by: Sarah <M.SarahGreyWolf@outlook.com>
Merged
sandtechnology
added a commit
that referenced
this issue
Mar 17, 2023
* PlayerFinder:Disable offline search when offline stash is enabled * Bump to 5.1.1.3 * Add progress report and try-catch block for offline player caching * Add error counting for caching offline player * Create crowdin ota workflow * Let workflow runs when translation PR merged * Use crowdin ids in secrets * Add okhttp shutdown logic on plugin disabling * Say hello to CrowdinOTA again Change crowdin requesting behavior to use timestamp querying files and not caching when querying manifest * New Crowdin translations by Github Action (#288) * Fix test * Fix test again * Fix messed okhttp cache folder * Temporary disable custom_languages field for wrong format See Ghost-chu/CrowdinCopyDeploy#1 * Fix enderchest shop not working * Refactor PlayerFinder and solve lag issue for real * Fix unwanted change to registerCustomCommands * PlayerFinder: use toLowerCase(Locale.ROOT) when updating * PlayerFinder: fix a bug which returning null for name2uuid * Disable the support of reloading DatabaseManager * Fix bug for bypassing item stacking option * Add user agent to http query * Fix a bug for got NPE when eco plugin not installed * Update LandsAPI ABI * Add include-offlineplayer-for-command option * Fix unit test for mojang api * Fix the bug about using static language * Update the doc in config.yml for this fix * #299 Set connectTimeout to 10 seconds * update mcbbs link (#310) * fix wrong update link * update link * update link * Update MCBBS Link * [ShopPurger] Add timeout to prevent crash server * SubCommand_Find: Add finding enchantments on enchanted books (#306) * SubCommand_Find: Add finding enchants on books * Reduce nested if's into singular if statement using && * Combine getBooksEnchantments and listContainsString into single function * Add missed imports --------- * Add manual trigger for crowdin workflow * New Crowdin translations by Github Action (#292) * #305 Fix wrong potionEffect level showing * Bump skyblock from 2.3.30 to 2.5.0 (#312) Bumps skyblock from 2.3.30 to 2.5.0. --- updated-dependencies: - dependency-name: com.songoda:skyblock dependency-type: direct:production update-type: version-update:semver-minor ... * Add listener to handle Spartan compatibility * Add missed soft depends for Spartan * #316 Delete wrong depends on ArmShopBridge * New Crowdin translations by Github Action (#313) * Refactor PriceLimiter Improve code readability Fix free shop price checking Fix digit checking not working other than shop creation Send detail message to player after price check failed * Fix wrong price in price error message * Add missed comment * Remove GroupManager check No idea why ghost adding this check, groupmanager should work along with QS * Fix maximumDigitsInPrice not working It should have extra # in formatting * Fix broken maximumDigitsInPrice config option and config version * Fix broken coloring * Fix javadoc for isBookEnchantmentsMatched method * Revert "Fix broken coloring" This reverts commit df93077. * Use modified MineDown to fix color issue * Fix price limit message not correct * Fix not calc the real tax in message when selling item (permission) * Add PlayerShopClickEvent and Deprecated ShopClickEvent * Add 1.19.4 support * New Crowdin translations by Github Action (#320) * Bump GriefPrevention from 16.18 to 16.18.1 (#324) Bumps [GriefPrevention](https://github.com/TechFortress/GriefPrevention) from 16.18 to 16.18.1. - [Release notes](https://github.com/TechFortress/GriefPrevention/releases) - [Commits](GriefPrevention/GriefPrevention@16.18...16.18.1) --- updated-dependencies: - dependency-name: com.github.TechFortress:GriefPrevention dependency-type: direct:production update-type: version-update:semver-patch ... * Bump SongodaCore from 2.6.16 to 2.6.18 (#303) Bumps SongodaCore from 2.6.16 to 2.6.18. --- updated-dependencies: - dependency-name: com.songoda:SongodaCore dependency-type: direct:production update-type: version-update:semver-patch ... * Bump LandsAPI from 6.26.18 to 6.28.11 (#314) Bumps [LandsAPI](https://github.com/Angeschossen/LandsAPI) from 6.26.18 to 6.28.11. - [Release notes](https://github.com/Angeschossen/LandsAPI/releases) - [Commits](IncrediblePlugins/LandsAPI@6.26.18...6.28.11) --- updated-dependencies: - dependency-name: com.github.angeschossen:LandsAPI dependency-type: direct:production update-type: version-update:semver-minor ... * Bump spigot-api from 1.19.3-R0.1-SNAPSHOT to 1.19.4-R0.1-SNAPSHOT (#325) Bumps spigot-api from 1.19.3-R0.1-SNAPSHOT to 1.19.4-R0.1-SNAPSHOT. --- updated-dependencies: - dependency-name: org.spigotmc:spigot-api dependency-type: direct:production update-type: version-update:semver-patch ... * Bump PlotSquared-Core from 6.10.5 to 6.11.1 (#321) Bumps [PlotSquared-Core](https://github.com/IntellectualSites/PlotSquared) from 6.10.5 to 6.11.1. - [Release notes](https://github.com/IntellectualSites/PlotSquared/releases) - [Commits](IntellectualSites/PlotSquared@6.10.5...6.11.1) --- updated-dependencies: - dependency-name: com.plotsquared:PlotSquared-Core dependency-type: direct:production update-type: version-update:semver-minor ... * Bump to 5.1.2.0 * Fix price change log recording wrong new price --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: YuanYuanOwO <81153017+YuanYuanOwO@users.noreply.github.com> Co-authored-by: Efe Kurban <efekurbann@gmail.com> Co-authored-by: Smudge <68658429+smuddgge@users.noreply.github.com> Co-authored-by: Sarah <M.SarahGreyWolf@outlook.com>
|
Fixed in 5.1.2.0 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When use-effect-for-potion-item is true the mcmmo fast digging II potions are shown as fast digging I potions on the sign.
Steps to reproduce
Expected Behaviour
I would expect it to say "Fast Digging II"
Screenshots
/qs pasteURLhttps://paste.helpch.at/awavonufew
Additional Context
No response
The text was updated successfully, but these errors were encountered: