[BUG] "The event is Deprecated" will still be prompted when using PlayerShopClickEvent #330
Comments
sandtechnology
added a commit
that referenced
this issue
Mar 18, 2023
|
This notice is not sent by us, and seems paper side will thinks the new event class extends deprecated event class still deprecated, so I do a change in this snapshot, it should no more notice again: https://ci.codemc.io/job/PotatoCraft-Studio/job/QuickShop-Reremake-SNAPSHOT/2490/ |
|
seems ok :D |
sandtechnology
added a commit
that referenced
this issue
Jun 21, 2023
* Bump to 5.1.2.1 for future developing * #330 Impl Deprecated event correctly * Fix coloring issue when using § * Fix coloring issue for item name using escape character * Fix coloring issue for item name using escape character again * [VirtualDisplayItem] Fix item name on floating item * New Crowdin translations by Github Action (#339) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * Bump lombok from 1.18.24 to 1.18.26 (#336) Bumps [lombok](https://github.com/projectlombok/lombok) from 1.18.24 to 1.18.26. - [Release notes](https://github.com/projectlombok/lombok/releases) - [Changelog](https://github.com/projectlombok/lombok/blob/master/doc/changelog.markdown) - [Commits](projectlombok/lombok@v1.18.24...v1.18.26) --- updated-dependencies: - dependency-name: org.projectlombok:lombok dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump openinvapi from 4.2.2 to 4.3.0 (#328) Bumps openinvapi from 4.2.2 to 4.3.0. --- updated-dependencies: - dependency-name: com.github.jikoo.OpenInv:openinvapi dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump item-nbt-api-plugin from 2.11.1 to 2.11.2 (#329) Bumps item-nbt-api-plugin from 2.11.1 to 2.11.2. --- updated-dependencies: - dependency-name: de.tr7zw:item-nbt-api-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix click event not working on multiple color preview text * Improve clickable preview text * Ignored custom build or 3rd fork in error reporter * Fix build * Handle NumberFormatException when trading * Fix reload command will crash plugin (using reload config instead) * Make sure the executing set to false after errored * Initial 1.20 support and fix test * Update libraries and re-enable songoda repo * Fix wording * itemi18n: Fix translation for trim pattern and handle item having desc * NBTAPI: 1.20 Support for setting sign text * Make sure sign nbt change was detected in the future version * Small refactor for setSignText * Fix NBTAPI changing sign not working * New Crowdin translations by Github Action (#341) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> (cherry picked from commit 2ee5f06) * Fix github build (skyblock 2.5.0->2.3.30) * [setSignText] Improve performance for paper (BlockState snapshot) * [setSignText] Fix ClassCastException * Update conflibot.yml * Update conflibot.yml * Update conflibot.yml * Update conflibot.yml * Bump LandsAPI from 6.28.11 to 6.29.12 (#356) Bumps [LandsAPI](https://github.com/Angeschossen/LandsAPI) from 6.28.11 to 6.29.12. - [Release notes](https://github.com/Angeschossen/LandsAPI/releases) - [Commits](IncrediblePlugins/LandsAPI@6.28.11...6.29.12) --- updated-dependencies: - dependency-name: com.github.angeschossen:LandsAPI dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump ProtocolLib from 5.0.0-SNAPSHOT to 5.0.0 (#353) Bumps ProtocolLib from 5.0.0-SNAPSHOT to 5.0.0. --- updated-dependencies: - dependency-name: com.comphenix.protocol:ProtocolLib dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump spigot-api from 1.20-R0.1-SNAPSHOT to 1.20.1-R0.1-SNAPSHOT (#361) * Bump spigot-api from 1.20-R0.1-SNAPSHOT to 1.20.1-R0.1-SNAPSHOT Bumps spigot-api from 1.20-R0.1-SNAPSHOT to 1.20.1-R0.1-SNAPSHOT. --- updated-dependencies: - dependency-name: org.spigotmc:spigot-api dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Update conflibot.yml * Update conflibot.yml --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sandtechnology <20417547+sandtechnology@users.noreply.github.com> * Bump openinvapi from 4.3.0 to 4.3.1 (#360) Bumps [openinvapi](https://github.com/Jikoo/OpenInv) from 4.3.0 to 4.3.1. - [Release notes](https://github.com/Jikoo/OpenInv/releases) - [Commits](Jikoo/OpenInv@4.3.0...4.3.1) --- updated-dependencies: - dependency-name: com.github.jikoo.OpenInv:openinvapi dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump worldguard-bukkit from 7.0.7 to 7.0.8 (#355) Bumps worldguard-bukkit from 7.0.7 to 7.0.8. --- updated-dependencies: - dependency-name: com.sk89q.worldguard:worldguard-bukkit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Merged
sandtechnology
added a commit
that referenced
this issue
Jun 22, 2023
* Bump to 5.1.2.1 for future developing * #330 Impl Deprecated event correctly * Fix coloring issue when using § * Fix coloring issue for item name using escape character * Fix coloring issue for item name using escape character again * [VirtualDisplayItem] Fix item name on floating item * New Crowdin translations by Github Action (#339) * Bump lombok from 1.18.24 to 1.18.26 (#336) Bumps [lombok](https://github.com/projectlombok/lombok) from 1.18.24 to 1.18.26. - [Release notes](https://github.com/projectlombok/lombok/releases) - [Changelog](https://github.com/projectlombok/lombok/blob/master/doc/changelog.markdown) - [Commits](projectlombok/lombok@v1.18.24...v1.18.26) --- updated-dependencies: - dependency-name: org.projectlombok:lombok dependency-type: direct:production update-type: version-update:semver-patch ... * Bump openinvapi from 4.2.2 to 4.3.0 (#328) Bumps openinvapi from 4.2.2 to 4.3.0. --- updated-dependencies: - dependency-name: com.github.jikoo.OpenInv:openinvapi dependency-type: direct:production update-type: version-update:semver-minor ... * Bump item-nbt-api-plugin from 2.11.1 to 2.11.2 (#329) Bumps item-nbt-api-plugin from 2.11.1 to 2.11.2. --- updated-dependencies: - dependency-name: de.tr7zw:item-nbt-api-plugin dependency-type: direct:production update-type: version-update:semver-patch ... * Fix click event not working on multiple color preview text * Improve clickable preview text * Ignored custom build or 3rd fork in error reporter * Fix build * Handle NumberFormatException when trading * Fix reload command will crash plugin (using reload config instead) * Make sure the executing set to false after errored * Initial 1.20 support and fix test * Update libraries and re-enable songoda repo * Fix wording * itemi18n: Fix translation for trim pattern and handle item having desc * NBTAPI: 1.20 Support for setting sign text * Make sure sign nbt change was detected in the future version * Small refactor for setSignText * Fix NBTAPI changing sign not working * New Crowdin translations by Github Action (#341) (cherry picked from commit 2ee5f06) * Fix github build (skyblock 2.5.0->2.3.30) * [setSignText] Improve performance for paper (BlockState snapshot) * [setSignText] Fix ClassCastException * Update conflibot.yml * Update conflibot.yml * Update conflibot.yml * Update conflibot.yml * Bump LandsAPI from 6.28.11 to 6.29.12 (#356) Bumps [LandsAPI](https://github.com/Angeschossen/LandsAPI) from 6.28.11 to 6.29.12. - [Release notes](https://github.com/Angeschossen/LandsAPI/releases) - [Commits](IncrediblePlugins/LandsAPI@6.28.11...6.29.12) --- updated-dependencies: - dependency-name: com.github.angeschossen:LandsAPI dependency-type: direct:production update-type: version-update:semver-minor ... * Bump ProtocolLib from 5.0.0-SNAPSHOT to 5.0.0 (#353) Bumps ProtocolLib from 5.0.0-SNAPSHOT to 5.0.0. --- updated-dependencies: - dependency-name: com.comphenix.protocol:ProtocolLib dependency-type: direct:production update-type: version-update:semver-patch ... * Bump spigot-api from 1.20-R0.1-SNAPSHOT to 1.20.1-R0.1-SNAPSHOT (#361) * Bump spigot-api from 1.20-R0.1-SNAPSHOT to 1.20.1-R0.1-SNAPSHOT Bumps spigot-api from 1.20-R0.1-SNAPSHOT to 1.20.1-R0.1-SNAPSHOT. --- updated-dependencies: - dependency-name: org.spigotmc:spigot-api dependency-type: direct:production ... * Update conflibot.yml * Update conflibot.yml --------- * Bump openinvapi from 4.3.0 to 4.3.1 (#360) Bumps [openinvapi](https://github.com/Jikoo/OpenInv) from 4.3.0 to 4.3.1. - [Release notes](https://github.com/Jikoo/OpenInv/releases) - [Commits](Jikoo/OpenInv@4.3.0...4.3.1) --- updated-dependencies: - dependency-name: com.github.jikoo.OpenInv:openinvapi dependency-type: direct:production update-type: version-update:semver-patch ... * Bump worldguard-bukkit from 7.0.7 to 7.0.8 (#355) Bumps worldguard-bukkit from 7.0.7 to 7.0.8. --- updated-dependencies: - dependency-name: com.sk89q.worldguard:worldguard-bukkit dependency-type: direct:production update-type: version-update:semver-patch ... --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When I tried to adapt my plugin to a new version of QuickShop, I found that PlayerShopClickEvent did not work as expected.
Code: https://github.com/RenYuan-MC/QuickShopForm/blob/master/src/main/java/ren/rymc/quickshopform/QuickShopForm.java
Steps to reproduce
Expected Behaviour
PlayerShopClickEvent should not be Deprecated
Screenshots
/qs pasteURLhttps://paste.helpch.at/amehizizaf
Additional Context
No response
The text was updated successfully, but these errors were encountered: