Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: [wip] implementation of the rescue functionality of the database server version used #155

Merged
merged 5 commits into from
Nov 26, 2021

Conversation

vs0uz4
Copy link
Contributor

@vs0uz4 vs0uz4 commented Nov 26, 2021

Due to some differences between the versions of some databases, I am proposing the use of a feature, where you tell us the version of the database server so we can customize and optimize the SQL responsible for sorting alphanumeric records

getServerVersion()
Captura de tela de 2021-11-26 01-53-52

With the help of this method, when we use the getSortSqlByDriver method to retrieve a specific SQL from one of the databases supported by laravel, in order to sort alphanumeric values more efficiently, we can tell the method not only the driver being used, but also the version of the database server being used. This way we can be more categorical in customizing the sorts.

ATTENTION
As I had suggested in PR(#149), I am in the current proposal, adjusting the database access ports, for each scenario currently created. This change concerns the following test scenario files:

  • phpunit.mysql.xml
  • phpunit.pgsql.xml
  • phpunit.sqlsrv.xml

So, to run the tests on one or all of the database scenarios with the help of the Docker containers, no changes to the files mentioned above are required.

Taking advantage of the port settings, I added another scenario for testing, this time for supporting the MS SQL Server database. These changes can be seen in the composer.json file.

@luanfreitasdev
Copy link
Collaborator

Thanks @vs0uz4 !

@luanfreitasdev luanfreitasdev merged commit 1f8cf04 into Power-Components:dev Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants