Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlSupport refactoring #156

Merged
merged 6 commits into from
Nov 26, 2021
Merged

SqlSupport refactoring #156

merged 6 commits into from
Nov 26, 2021

Conversation

dansysanalyst
Copy link
Member

Hi Luan,

According to Laravel 8x - Database PowerGrid should be supporting:

  • MySQL 5.7+ (Version Policy)
  • PostgreSQL 9.6+ (Version Policy)
  • SQLite 3.8.8+
  • SQL Server 2017+ (Version Policy)

I wrote a test to verify the sortField syntax for database + version. I do not remember if we had an alternative solution for the field+0. For the moment, I left it as default for situations:

Screenshot 2021-11-26 at 16 09 10

All tests passing, could not test Sql Server locally.

Screenshot 2021-11-26 at 16 09 35

Static analysis also OK on the desired level.

Screenshot 2021-11-26 at 16 09 51

@vs0uz4 I have not touched the docker-compose; however, I think it would be best to also downgrade it to make sure tests run in the minimum supported database.

Hopefully, it solves the compatibility problem.

Thanks

@dansysanalyst dansysanalyst requested a review from vs0uz4 November 26, 2021 15:17
Copy link
Contributor

@vs0uz4 vs0uz4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dan, this implementation of driver and version verification is too beautiful, congratulations. And these tests, huh? Wow, you really went all out in PR. Very well approved.

@luanfreitasdev luanfreitasdev added the enhancement New feature or request label Nov 26, 2021
@luanfreitasdev
Copy link
Collaborator

Thansk @dansysanalyst , @vs0uz4

@luanfreitasdev luanfreitasdev merged commit 77f8a74 into Power-Components:dev Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants