Merge pull request #47 from alagoutte/update-github-pssa

PSSA (github): Update to use docker image (2.3.0)
PowerAruba · Feb 22, 2021 · 7af5751 · 7af5751
2 parents e99d5ed + f83373d
commit 7af5751
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 10 deletions.
diff --git a/.github/workflows/pssa.yml b/.github/workflows/pssa.yml
@@ -1,13 +1,18 @@
+
 name: CI
-on: [pull_request]
+on:
+  pull_request:
 jobs:
   lint:
     name: Run PSSA
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v1
-    - name: lint
-      uses: devblackops/github-action-psscriptanalyzer@master
-      with:
-        repoToken: ${{ secrets.GITHUB_TOKEN }}
-        settingsPath: .vscode/PSScriptAnalyzerSettings.psd1
+      - uses: actions/checkout@master
+      - name: lint
+        uses:   docker://devblackops/github-action-psscriptanalyzer:2.3.0
+        with:
+          settingsPath: .vscode/PSScriptAnalyzerSettings.psd1
+          sendComment: false
+          failOnInfos: true
+          failOnErrors: true
+          failOnWarnings: true
diff --git a/PowerArubaCP/Public/ApplicationLicense.ps1 b/PowerArubaCP/Public/ApplicationLicense.ps1
@@ -84,6 +84,7 @@ function Get-ArubaCPApplicationLicense {
 
     #>
 
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSReviewUnusedParameter")] #False positive see https://github.com/PowerShell/PSScriptAnalyzer/issues/1472
     [CmdLetBinding(DefaultParameterSetName = "Default")]
 
     Param(
@@ -105,7 +106,7 @@ function Get-ArubaCPApplicationLicense {
 
     Process {
 
-        if($connection.version -lt [version]"6.8.0"){
+        if ($connection.version -lt [version]"6.8.0") {
             throw "Need ClearPass >= 6.8.0 for use this cmdlet"
         }
 

diff --git a/PowerArubaCP/Public/Connection.ps1 b/PowerArubaCP/Public/Connection.ps1
@@ -172,7 +172,7 @@ function Disconnect-ArubaCP {
         if ($decision -eq 0) {
             Write-Progress -activity "Remove Aruba ClearPass connection"
             write-progress -activity "Remove Aruba ClearPass connection" -completed
-            if ( Test-Path variable:global:DefaultArubaCPConnection ) {
+            if ( ($connection -eq $DefaultArubaCPCOnnection) -and (Test-Path variable:global:DefaultArubaCPConnection) ) {
                 Remove-Variable -name DefaultArubaCPConnection -scope global
             }
         }

diff --git a/PowerArubaCP/Public/Platform.ps1 b/PowerArubaCP/Public/Platform.ps1
@@ -59,7 +59,7 @@ function Get-ArubaCPServerConfiguration {
 
     #>
 
-
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSReviewUnusedParameter")] #False positive see https://github.com/PowerShell/PSScriptAnalyzer/issues/1472
     [CmdLetBinding(DefaultParameterSetName = "Default")]
 
     Param(
-Original file line number
+Diff line change
@@ Expand Up / @@ -59,7 +59,7 @@ function Get-ArubaCPServerConfiguration { @@
         #>
+        [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSReviewUnusedParameter")] #False positive see https://github.com/PowerShell/PSScriptAnalyzer/issues/1472
         [CmdLetBinding(DefaultParameterSetName = "Default")]
         Param(
@@ Expand Down @@