Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not merge: centos 10 stream support in builder #14473

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Jul 16, 2024

Short description

this is hacked up instead of done nicely.
Once EPEL10 becomes available, we can re-enable sodium, re2, etc. and do this nicely, and then start building it periodically to prepare us for RHEL10 (next year I think)

only tested for dnsdist

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

this is hacked up instead of done nicely.
Once EPEL10 becomes available, we can re-enable sodium, re2, etc. and do this nicely.

only tested for dnsdist
@Habbie Habbie added this to the common-helpneeded milestone Jul 16, 2024
@coveralls
Copy link

coveralls commented Jul 16, 2024

Pull Request Test Coverage Report for Build 10633592297

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5702 unchanged lines in 99 files lost coverage.
  • Overall coverage decreased (-0.04%) to 64.658%

Files with Coverage Reduction New Missed Lines %
pdns/dnsdistdist/dnsdist-session-cache.cc 1 62.86%
pdns/dnspacket.hh 1 94.44%
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/recursordist/rec-tcounters.hh 1 96.84%
pdns/dnsdistdist/dnsdist-lbpolicies.hh 1 64.29%
pdns/dnsdistdist/test-dnsdistrules_cc.cc 1 95.15%
pdns/dnsdistdist/test-dnsdistnghttp2-in_cc.cc 1 85.12%
pdns/recursordist/aggressive_nsec.cc 2 66.17%
pdns/dnsdistdist/test-dnsdist-lua-ffi.cc 2 99.57%
pdns/distributor.hh 2 51.86%
Totals Coverage Status
Change from base Build 9953964411: -0.04%
Covered Lines: 124663
Relevant Lines: 162088

💛 - Coveralls

@Habbie
Copy link
Member Author

Habbie commented Aug 30, 2024

With EPEL10 now available (but not yet complete), this has dnsdist, recursor, auth, minus geoipbackend and ixfrdist (because yaml-cpp), normal lua instead of luajit (should become available soon), and I took out h2o just because I did not feel like debugging it it if it wouldn't work.

@Habbie
Copy link
Member Author

Habbie commented Oct 18, 2024

also tested against re2-20240702-3 now (which is an upcoming ABI-incompatible version bump in EPEL10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants