Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with boost 1.86.0 #14562

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Fix build with boost 1.86.0 #14562

merged 1 commit into from
Aug 19, 2024

Conversation

cho-m
Copy link
Contributor

@cho-m cho-m commented Aug 16, 2024

Short description

Boost 1.86.0 changes seem to no longer indirectly include header which causes build to fail with:

uuid-utils.cc:38:58: error: 'random' is not a class, namespace, or enumeration
thread_local boost::uuids::basic_random_generator<boost::random::mt19937> t_uuidGenerator;
                                                         ^

boost/random/mersenne_twister.hpp has been available since Boost 1.21.2

Seen when updating Boost in Homebrew Homebrew/homebrew-core#181332

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

Boost 1.86.0 changes seem to no longer indirectly include header which
causes build to fail with:
```
uuid-utils.cc:38:58:
error: 'random' is not a class, namespace, or enumeration
```

boost/random/mersenne_twister.hpp has been available since Boost 1.21.2
@Habbie Habbie added this to the common-soon milestone Aug 19, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10413973749

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 84 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.01%) to 64.668%

Files with Coverage Reduction New Missed Lines %
pdns/packethandler.cc 1 72.26%
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/misc.cc 1 63.26%
pdns/recursordist/aggressive_nsec.cc 2 65.95%
pdns/sstuff.hh 2 56.83%
pdns/stubresolver.cc 3 77.58%
pdns/dnsdistdist/dnsdist.cc 4 68.65%
pdns/recursordist/rec-tcpout.cc 5 50.79%
pdns/ssqlite3.cc 5 66.46%
pdns/recursordist/test-syncres_cc1.cc 6 89.55%
Totals Coverage Status
Change from base Build 10368283481: -0.01%
Covered Lines: 124607
Relevant Lines: 162035

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants