Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finally fix the clang-tidy issues. #14788

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

omoerbeek
Copy link
Member

Root cause was the slightly different parsing or the Checks: line, newer version handle the single quotes differently. Also remove two entries that are not present on older clang-tidy implementations.

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

Root cause was the slightly different parsing or the Checks: line, newer version handle the single quotes differently.
Also remove two entries that are not present on older clang-tidy implementations.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11435692867

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 36 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.8%) to 64.642%

Files with Coverage Reduction New Missed Lines %
pdns/recursordist/aggressive_nsec.cc 2 66.1%
modules/lmdbbackend/lmdbbackend.cc 2 73.53%
pdns/rcpgenerator.cc 2 89.5%
pdns/dnsdistdist/dnsdist.cc 2 68.38%
pdns/signingpipe.cc 5 83.91%
pdns/recursordist/syncres.cc 7 79.7%
pdns/dnsdistdist/dnsdist-tcp.cc 8 75.74%
pdns/recursordist/ext/luawrapper/include/LuaContext.hpp 8 14.17%
Totals Coverage Status
Change from base Build 11427037509: 0.8%
Covered Lines: 124758
Relevant Lines: 162261

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants