Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbreak local running of auth regression tests #14828

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Nov 6, 2024

Short description

Revert "Cleanup"

This reverts commit 48c1892 (part of #14621).

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

This reverts commit 48c1892.
@Habbie Habbie added the auth label Nov 6, 2024
@Habbie Habbie added this to the auth-5 milestone Nov 6, 2024
@coveralls
Copy link

coveralls commented Nov 6, 2024

Pull Request Test Coverage Report for Build 11704399497

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 49 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.02%) to 64.714%

Files with Coverage Reduction New Missed Lines %
pdns/dnsdistdist/dnsdist-backend.cc 1 64.94%
pdns/axfr-retriever.cc 3 67.89%
pdns/misc.cc 3 64.0%
pdns/iputils.cc 3 55.91%
pdns/rcpgenerator.cc 3 89.86%
pdns/signingpipe.cc 5 83.91%
pdns/recursordist/rec-tcpout.cc 6 50.79%
pdns/recursordist/rec-main.cc 7 62.47%
modules/godbcbackend/sodbc.cc 18 70.8%
Totals Coverage Status
Change from base Build 11703802105: 0.02%
Covered Lines: 125792
Relevant Lines: 163578

💛 - Coveralls

@jsoref
Copy link
Contributor

jsoref commented Nov 6, 2024

I don't see how this does anything.

Don't you need to revert fredmorcos@1f3d36c too?

@omoerbeek
Copy link
Member

I don't see how this does anything.

Don't you need to revert [fredmorcos/pdns@1f3d36c](fredmorcos@1f3d36c

The file sources a couple of files, including regressions/test/common, which uses ${MAKE}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants