Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: coverity fixes, all minor optimizations #14896

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

omoerbeek
Copy link
Member

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@omoerbeek omoerbeek added the rec label Nov 27, 2024
@omoerbeek omoerbeek added this to the rec-5.2.0 milestone Nov 27, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12046188202

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • 84 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-8.4%) to 64.693%

Files with Coverage Reduction New Missed Lines %
pdns/dnsdistdist/dnsdist-crypto.cc 1 76.01%
pdns/recursordist/test-syncres_cc2.cc 3 88.91%
pdns/iputils.hh 3 78.29%
pdns/misc.cc 3 63.49%
pdns/iputils.cc 3 55.76%
pdns/rcpgenerator.cc 3 89.92%
pdns/recursordist/rec-tcp.cc 5 65.47%
pdns/dnsdistdist/dnsdist-tcp.cc 8 75.79%
pdns/recursordist/syncres.cc 10 79.64%
pdns/recursordist/taskqueue.cc 11 34.15%
Totals Coverage Status
Change from base Build 12034691735: -8.4%
Covered Lines: 125855
Relevant Lines: 163658

💛 - Coveralls

@omoerbeek omoerbeek merged commit 8e773ea into PowerDNS:master Nov 29, 2024
78 checks passed
@omoerbeek omoerbeek deleted the rec-coverity-20241127 branch November 29, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants