JSON API: uppercase types #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
@mind04 suggested doing the uppercasing in the QType string constructor instead, which makes sense to me |
|
@mind04 do you mind submitting your PR on powerdns/pdns instead of my fork? |
Plus update JSON API tests to test for this (from @zeha).
zeha
force-pushed
the
json-uppercase-types
branch
from
b53ef2e
to
8ce0dc7
Compare
|
I did some git magic and squashed your PR into mine and attributed it to you. ;-) |
|
Oh there it is! I saw the notification somewhere but then was unable to find it here ;) |
|
Will merge after Travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never promised that types can be in lowercase, but given we're
interpreting them as TYPE0 instead of flat-out failing, let's be nicer.