dnsdist: Reset origFD asap to keep the outstanding count correct #4365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the health check thread waited until we had finished
with the IDState to set
origFD
to -1, but:outstanding
will not be incremented iforigFD
is not -1,which is not what we want since we are going to decrement it
likelihood of decrementing
outstanding
twice, once in theresponder threader and once in the health check thread.
This was especially likely to be an issue because the health check
thread used to call
gettime()
and to acquire a mutex beforesetting
origFD
to -1.This might help with #4344.