logger: Use thread_local, move config into a function-level static variable #6639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on NetBSD, and verified to fix the crash I reported in #6624. |
zeha
reviewed
May 22, 2018
pdns/logger.cc
Outdated
|
|
||
| static Logger::Config& getLoggerConfig() | ||
| { | ||
| static Logger::Config config; |
There was a problem hiding this comment.
"magic" code should have a comment, if you ask me (:
|
As previously mentioned, this fixes my NetBSD/amd64 crash, and both the auth server and the recursor work (and log) fine with these patches installed. On NetBSD/arm, however (the 32 bit arm platform, to be specific), the auth server is fine, but the recursor crashes. The backtrace looks exactly like what I saw on NetBSD/amd64 without your patch, and it happens at the first logging attempt made by recursorThread(); the "Done priming cache with root hints" one. Might there be something the recursor isn't doing during startup, that it ought to? |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR includes the commit from #6625 and additionally move the
Loggerconfiguration to a different struct kept inside a function-level static variable, making sure it's always properly initialized before being used.The diff is not very large and should not be harder to maintain and use than the current version. It avoids relying on an undefined order of initialization that might prove a more serious issue in the future.
Checklist
I have: