rec: Support exporting more record types via protobuf #6708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Several users have reported the need to export the content of of more record types found in responses. This pull request adds support for optionally exporting the content of
MX
,NS
,PTR
,SPF
,SRV
andTXT
record types, in addition to the existingA
,AAAA
andCNAME
. The implementation is limited to those types because it special cases them.An other option would be to implement all
xfr*()
methods to be able to get the "wire version" of all types. If we decided to go that road, I think it might make sense to extract thexfr*()
methods fromDNSPacketWriter
into aDNSRecordWriter
implementing allxfr*()
methods, that would be called byDNSPacketWriter
but could also be used from the protobuf logger.This PR is based on #6698 and will need a rebase after it has been merged.
Checklist
I have: