Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis dangling symlinks #7028

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Oct 5, 2018

Short description

Yak: recursor and dnsdist rely on symlinks into the 'main' pdns source tree. Travis should check for dangling symlinks.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@jsoref
Copy link
Contributor Author

jsoref commented Oct 5, 2018

https://travis-ci.org/PowerDNS/pdns/jobs/437438861

cd pdns/recursordist
$ for a in $(find * -type l|egrep -v "pubsuffix.cc|missing-sources|so$"); do [ ! -e $a ] && echo found dangling symlink $a && exit 1; done
found dangling symlink no-such-file
The command "./build-scripts/travis.sh" exited with 1.
Done. Your build exited with 1.

@jsoref jsoref force-pushed the travis-dangling-symlinks branch 2 times, most recently from fdfb34d to 11bc413 Compare October 5, 2018 18:47
build-scripts/travis.sh Outdated Show resolved Hide resolved
@jsoref jsoref force-pushed the travis-dangling-symlinks branch 6 times, most recently from 166df29 to b886b0d Compare October 8, 2018 20:51
@jsoref
Copy link
Contributor Author

jsoref commented Oct 8, 2018

Here's the final tested version:

$ ! find -L . -name missing-sources -prune -o ! -name pubsuffix.cc -type l | grep .
./dangling-two
./dangling-one
The command "! find -L . -name missing-sources -prune -o ! -name pubsuffix.cc -type l | grep ." failed and exited with 1 during .
Your build has been stopped.

https://travis-ci.org/PowerDNS/pdns/jobs/438777874

@rgacogne
Copy link
Member

rgacogne commented Oct 9, 2018

rec is failing to build, rebasing on top of #7044 should fix it, sorry!

@pieterlexis pieterlexis merged commit c7f12a5 into PowerDNS:master Oct 10, 2018
@jsoref jsoref deleted the travis-dangling-symlinks branch October 10, 2018 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants