Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename supermaster to superslave, and mention in upgrade notes #7723

Merged
merged 1 commit into from
May 2, 2019
Merged

rename supermaster to superslave, and mention in upgrade notes #7723

merged 1 commit into from
May 2, 2019

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Apr 15, 2019 •
edited
Loading

Short description

The old name was very confusing. Fixes #7720.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@Habbie Habbie added this to the auth-4.2.0 milestone Apr 15, 2019
@Habbie
Copy link
Member Author

Habbie commented Apr 15, 2019

This SHOULD fail on Travis.

@Habbie
Copy link
Member Author

Habbie commented Apr 15, 2019

This SHOULD fail on Travis.

Right after pushing, I noticed I forgot to fix the supermaster tests in regression-tests.nobackend. I decided to let Travis run to see if they would in fact fail, and they did. I have now amended the commit to update those too, and now Travis should pass.

@Habbie
Copy link
Member Author

Habbie commented Apr 15, 2019

This has passed on Travis.

@Habbie Habbie modified the milestones: auth-4.2.0, auth-4.2.0-rc2 Apr 29, 2019
@Habbie Habbie requested a review from pieterlexis May 2, 2019 09:18
@pieterlexis pieterlexis merged commit 527977c into PowerDNS:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieterlexis pieterlexis Awaiting requested review from pieterlexis

Assignees
No one assigned
Labels
auth defect docs
Projects
None yet
Milestone
auth-4.2.0-rc2
Development

Successfully merging this pull request may close these issues.

Auth 4.2 supermaster setting clarification
2 participants
@Habbie @pieterlexis