Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh benchmark with columnar data #13

Merged
merged 10 commits into from
Nov 29, 2024
Merged

Refresh benchmark with columnar data #13

merged 10 commits into from
Nov 29, 2024

Conversation

TonyXiang8787
Copy link
Member

Do not pay attention to the result yet. It was a trial run. Please review on the code.

@TonyXiang8787
change requirement
d59f34f 
Signed-off-by: Tony Xiang <tonyxiang@live.nl>
@TonyXiang8787
fix bug
7e58b05 
Signed-off-by: Tony Xiang <tonyxiang@live.nl>
@TonyXiang8787
columnar input
28f0ea4 
Signed-off-by: Tony Xiang <tonyxiang@live.nl>
@TonyXiang8787
output columnar
3ded7e0 
Signed-off-by: Tony Xiang <tonyxiang@live.nl>
@TonyXiang8787
n-1 columnar
ad81e45 
Signed-off-by: Tony Xiang <tonyxiang@live.nl>
@TonyXiang8787
re-run
b67b56a 
Signed-off-by: Tony Xiang <tonyxiang@live.nl>
mgovers
mgovers approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review LGTM. as you requested, I did not dive into numerical results. Feel free to resolve my comment and merge

generate_fictional_dataset.py Show resolved Hide resolved
@TonyXiang8787
re-run
46b4a8a 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
Copy link
Member Author

@mgovers please review on the values

@TonyXiang8787
re-run
6a1a2a7 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
mgovers
mgovers reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewing shows a consistent pattern when diffing against the previous run:

  • for symmetric calculations, the difference between PGM and PP is smaller than it used to be
  • for asymmetric calculations, the difference seems to have increased (which is good for us)

Power Grid Model Benchmark.ipynb Show resolved Hide resolved
Power Grid Model Benchmark.ipynb Show resolved Hide resolved
Power Grid Model Benchmark.ipynb Outdated Show resolved Hide resolved
Power Grid Model Benchmark.ipynb Outdated Show resolved Hide resolved
Power Grid Model Benchmark.ipynb Outdated Show resolved Hide resolved
Power Grid Model Benchmark.ipynb Outdated Show resolved Hide resolved
Power Grid Model Benchmark.ipynb Outdated Show resolved Hide resolved
Power Grid Model Benchmark.ipynb Outdated Show resolved Hide resolved
Power Grid Model Benchmark.ipynb Outdated Show resolved Hide resolved
@TonyXiang8787
remvoe verbose
7a30e1f 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
re-run
0c0e45e 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
Copy link
Member Author

@mgovers now re-run without verbose. I think we can merge it. The numbers are within the run-variations for PGM. The reason why pandapower asymmetric is slower is unknown. They are slow anyway...

@TonyXiang8787 TonyXiang8787 merged commit 04bfcf3 into main Nov 29, 2024
2 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/refresh-benchmark-with-columnar branch November 29, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgovers mgovers mgovers approved these changes

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TonyXiang8787 @mgovers