Skip to content

Conversation

@mgovers
Copy link
Member

@mgovers mgovers commented Dec 11, 2025

PGM-IO equivalent of PowerGridModel/power-grid-model#1206

Enables uv in build and CI.
Also homogenizes pre-commit, markdownlint and enables mypy

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers self-assigned this Dec 11, 2025
@mgovers mgovers added the improvement Existing functionality, but better, faster, stronger label Dec 11, 2025
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers marked this pull request as ready for review December 12, 2025 07:54
@mgovers mgovers enabled auto-merge December 12, 2025 07:56
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@sonarqubecloud
Copy link

@mgovers mgovers mentioned this pull request Dec 15, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can think about later to put this whole stuff into a different action.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make an action out of this and keep maintenance in one place only.

Note: Unresolving for visibility - Resolve once seen.


examples = [
"power-grid-model>1.9.80",
"pandapower>2.11.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still true? If I recall correctly we may need way more updated than this version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd say that's a separate PR if so.

do you have some time to check this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make time for it and make a separate PR then

dev = [{ include-group = "test" }, { include-group = "lint" }]

examples = [
"power-grid-model>1.9.80",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also hold still?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd say that's a separate PR if so.

do you have some time to check this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make time for it and make a separate PR then

```
pip install power-grid-model-io
```sh
uv add power-grid-model-io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be more generally uv pip install power-grid-model-io?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uv add and uv pip are equivalent except that pip actually is considered legacy behavior because it may dirty your virtual environment in an unmanaged way, while in add, everything remains uv-managed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful with uv add, it actually changes pyproject.toml file. So it cannot be used as an ad-hoc installation of some package to try in your environment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make an action out of this and keep maintenance in one place only.

Note: Unresolving for visibility - Resolve once seen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Existing functionality, but better, faster, stronger

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants