-
Notifications
You must be signed in to change notification settings - Fork 12
Enable UV in build and CI #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can think about later to put this whole stuff into a different action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make an action out of this and keep maintenance in one place only.
Note: Unresolving for visibility - Resolve once seen.
|
|
||
| examples = [ | ||
| "power-grid-model>1.9.80", | ||
| "pandapower>2.11.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still true? If I recall correctly we may need way more updated than this version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd say that's a separate PR if so.
do you have some time to check this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make time for it and make a separate PR then
| dev = [{ include-group = "test" }, { include-group = "lint" }] | ||
|
|
||
| examples = [ | ||
| "power-grid-model>1.9.80", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this also hold still?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd say that's a separate PR if so.
do you have some time to check this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make time for it and make a separate PR then
| ``` | ||
| pip install power-grid-model-io | ||
| ```sh | ||
| uv add power-grid-model-io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be more generally uv pip install power-grid-model-io?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uv add and uv pip are equivalent except that pip actually is considered legacy behavior because it may dirty your virtual environment in an unmanaged way, while in add, everything remains uv-managed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be careful with uv add, it actually changes pyproject.toml file. So it cannot be used as an ad-hoc installation of some package to try in your environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make an action out of this and keep maintenance in one place only.
Note: Unresolving for visibility - Resolve once seen.



PGM-IO equivalent of PowerGridModel/power-grid-model#1206
Enables uv in build and CI.
Also homogenizes pre-commit, markdownlint and enables
mypy