resolve comments + fix ci

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
PowerGridModel · Dec 3, 2024 · 81936f6 · 81936f6
1 parent 8f5862f
commit 81936f6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/power_grid_model_c/power_grid_model/include/power_grid_model/common/enum.hpp b/power_grid_model_c/power_grid_model/include/power_grid_model/common/enum.hpp
@@ -24,7 +24,7 @@ enum class ControlSide : IntS { from = 0, to = 1, side_1 = 0, side_2 = 1, side_3
 
 enum class CalculationType : IntS { power_flow = 0, state_estimation = 1, short_circuit = 2 };
 
-enum class CalculationSymmetry : IntS { symmetric = 1, asymmetric = 2 };
+enum class CalculationSymmetry : IntS { asymmetric = 0, symmetric = 1 };
 
 enum class CalculationMethod : IntS {
     default_method = -128,

diff --git a/tests/native_api_tests/test_api_model_update.cpp b/tests/native_api_tests/test_api_model_update.cpp
@@ -778,9 +778,8 @@ TEST_CASE("API model - incomplete input") {
                                                        complete_update_data));
                 }
 
-                for (Idx node_idx = 0; node_idx < complete_state.node_id.size(); ++node_idx) {
+                for (Idx node_idx = 0; node_idx < std::ssize(complete_state.node_id); ++node_idx) {
                     CAPTURE(node_idx);
-                    auto const node_offset = node_idx * MetaData::component_size(node_output_meta);
 
                     for (Idx attr_idx = 0; attr_idx < MetaData::n_attributes(node_output_meta); ++attr_idx) {
                         auto const* attr_meta = MetaData::get_attribute_by_idx(node_output_meta, attr_idx);