Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pypa/cibuildwheel from 2.14.1 to 2.15.0 #352

Merged
merged 8 commits into from
Aug 15, 2023
Merged

Bump pypa/cibuildwheel from 2.14.1 to 2.15.0 #352

merged 8 commits into from
Aug 15, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 14, 2023

Bumps pypa/cibuildwheel from 2.14.1 to 2.15.0.

Release notes

Sourced from pypa/cibuildwheel's releases.

v2.15.0

  • 🌟 CPython 3.12 wheels are now built by default - without the CIBW_PRERELEASE_PYTHONS flag. It's time to build and upload these wheels to PyPI! This release includes CPython 3.12.0rc1, which is guaranteed to be ABI compatible with the final release. (#1565)
  • ✨ Adds musllinux_1_2 support - this allows packagers to build for musl-based Linux distributions on a more recent Alpine image, and a newer musl libc. (#1561)
Changelog

Sourced from pypa/cibuildwheel's changelog.

v2.15.0

8 August 2023

  • 🌟 CPython 3.12 wheels are now built by default - without the CIBW_PRERELEASE_PYTHONS flag. It's time to build and upload these wheels to PyPI! This release includes CPython 3.12.0rc1, which is guaranteed to be ABI compatible with the final release. (#1565)
  • ✨ Adds musllinux_1_2 support - this allows packagers to build for musl-based Linux distributions on a more recent Alpine image, and a newer musl libc. (#1561)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Bump pypa/cibuildwheel from 2.14.1 to 2.15.0
0d3e2c9 
Bumps [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel) from 2.14.1 to 2.15.0.
- [Release notes](https://github.com/pypa/cibuildwheel/releases)
- [Changelog](https://github.com/pypa/cibuildwheel/blob/main/docs/changelog.md)
- [Commits](pypa/cibuildwheel@v2.14.1...v2.15.0)

---
updated-dependencies:
- dependency-name: pypa/cibuildwheel
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 14, 2023
@TonyXiang8787
Use musllinux 1.2
8f7d667 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
TonyXiang8787
TonyXiang8787 previously approved these changes Aug 14, 2023
View reviewed changes
@TonyXiang8787
Copy link
Member

@mgovers Can you have a look at this one? I guess some dev dependencies do not support Python 3.12 yet.

@mgovers
Copy link
Member

mgovers commented Aug 14, 2023

@mgovers Can you have a look at this one? I guess some dev dependencies do not support Python 3.12 yet.

OH i found the same issue on my branch. was wondering what it was. will investigate

@mgovers
Copy link
Member

mgovers commented Aug 14, 2023

@mgovers Can you have a look at this one? I guess some dev dependencies do not support Python 3.12 yet.

OH i found the same issue on my branch. was wondering what it was. will investigate

correction: my error is a different one, just in the same step 😢

@mgovers
Copy link
Member

mgovers commented Aug 14, 2023

distutils doesn't exist anymore starting python 3.12 cfr. https://peps.python.org/pep-0632/ but apparently it is still being included by the setuptools version used in CI. This bug was reported in pypa/setuptools#3661 . It has since been closed but i will have to investigate further on whether that fix can already be used by us or whether the fact that we use manylinux will pose an issue here

@mgovers
force setuptools recent version
46c75a7 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@TonyXiang8787
Copy link
Member

TonyXiang8787 commented Aug 15, 2023 •
edited
Loading

@mgovers the problem is numpy does not support Python 3.12 yet as pre-built binary. So we cannot support that.

Just add python_requires >=3.8 <3.12. We do not need a version pin on setuptools.

@mgovers
Copy link
Member

mgovers commented Aug 15, 2023 •
edited
Loading

finally able to repro locally:

  • install python 3.12.0b3
  • python -m virtualenv -p <path/to/python/3.12.0b3/python> venv-3.12
  • venv-3.12/Scripts/activate (or source venv-3.12/bin/activate for unix, obviously)
  • python -m pip install .

mgovers added 2 commits August 15, 2023 14:04
@mgovers
exclude python3.12
4fe3441 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
update CI build wheel options
6a8d2f6 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
TonyXiang8787
TonyXiang8787 reviewed Aug 15, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@mgovers
Revert "update CI build wheel options"
7879ecc 
This reverts commit 6a8d2f6.

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TonyXiang8787 TonyXiang8787 merged commit eb37bbe into main Aug 15, 2023
@TonyXiang8787 TonyXiang8787 deleted the dependabot/github_actions/pypa/cibuildwheel-2.15.0 branch August 15, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgovers mgovers mgovers left review comments

@TonyXiang8787 TonyXiang8787 TonyXiang8787 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TonyXiang8787 @mgovers