Feature/transformer ranking step 4 #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update branch
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
…eight) Subject to further changes after step 1 is concluded. someone should take a look at clang-tidy Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
mgovers
reviewed
Apr 3, 2024
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Show resolved
Hide resolved
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
|
mgovers
approved these changes
Apr 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative implementation of step 4. Notice that the return type of
rank_transformeris now a vector of vector, meaning that each group contains one or more trafo with equal trafo edge weight / rank. This is the result of the discussion of not having an order within same rank. Code might need further change once step 1 is finalized, but now it is clear what is expected.