Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.9 #638

Merged
merged 11 commits into from
Jul 15, 2024
Merged

Drop python 3.9 #638

merged 11 commits into from
Jul 15, 2024

Conversation

Jerry-Jinfeng-Guo
Copy link
Contributor

No description provided.

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added dependencies Pull requests that update a dependency file do-not-merge This should not be merged labels Jun 11, 2024
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo self-assigned this Jun 11, 2024
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@mgovers
Copy link
Member

mgovers commented Jun 11, 2024

are you sure it's a good idea to do this right after the release of v1.8.0? what if there are important bugfixes? I'd propose to do this change at least a week from now

EDIT: i saw the do-not-merge label 👍

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo marked this pull request as ready for review July 9, 2024 13:32
@TonyXiang8787 TonyXiang8787 removed the do-not-merge This should not be merged label Jul 10, 2024
@TonyXiang8787 TonyXiang8787 added this pull request to the merge queue Jul 10, 2024
@mgovers mgovers removed this pull request from the merge queue due to a manual request Jul 10, 2024
@mgovers
Copy link
Member

mgovers commented Jul 10, 2024

@TonyXiang8787 @Jerry-Jinfeng-Guo I think it's good to wait with dropping Python 3.9 support until #672 is merged so that users that are pinned to Python 3.9 still have the benefits of that

@mgovers
Copy link
Member

mgovers commented Jul 12, 2024

Scheduled for Monday morning (to prevent Friday afternoon releases)

Copy link

@figueroa1395 figueroa1395 added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit b20541d Jul 15, 2024
26 checks passed
@figueroa1395 figueroa1395 deleted the feature/drop-python-39 branch July 15, 2024 08:28
@mgovers mgovers mentioned this pull request Nov 5, 2024
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants