Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove erroneously added unused and test logic after #668 #684

Merged
merged 1 commit into from
Aug 6, 2024
Merged

remove erroneously added unused and test logic after #668 #684

merged 1 commit into from
Aug 6, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Aug 6, 2024 •
edited
Loading

Partially reverts #668

  • Reverts adding unused exception type
  • Reverts adding test logic that causes actual issues to remain hidden
  • Reverts adding unused test parameters

@mgovers
remove erroneously added test logic after #668
9f11250 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added the bug Something isn't working label Aug 6, 2024
@mgovers mgovers enabled auto-merge August 6, 2024 10:27
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny the small unused imports are not discovered by the autoation

@mgovers mgovers added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit 82168c6 Aug 6, 2024
26 checks passed
@mgovers mgovers deleted the feature/partial-revert-binary-search branch August 6, 2024 12:03
@mgovers mgovers mentioned this pull request Nov 5, 2024
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figueroa1395 figueroa1395 figueroa1395 left review comments

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgovers @Jerry-Jinfeng-Guo @figueroa1395