Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path changes to cmake files #689

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Path changes to cmake files #689

merged 2 commits into from
Aug 13, 2024

Conversation

Laurynas-Jagutis
Copy link
Member

This change would help with making PGM as a submodule more self-contained and modular. Previously, if PGM was used as a submodule in another project, there would arise issues with cmake paths, since CMAKE_SOURCE_DIR would take the root directory of the other project (where PGM is used as a submodule) instead of the root directory of PGM.

Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis Laurynas-Jagutis added the improvement Improvement on internal implementation label Aug 12, 2024
@Laurynas-Jagutis Laurynas-Jagutis marked this pull request as ready for review August 12, 2024 11:28
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PROJECT_SOURCE_DIR is more accurate, because it refers to the cmake/ dir relative to the power_grid_model project

cmake/export_power_grid_model.cmake Outdated Show resolved Hide resolved
cmake/export_power_grid_model.cmake Outdated Show resolved Hide resolved
cmake/export_power_grid_model.cmake Show resolved Hide resolved
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
Copy link

@mgovers mgovers added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit a81a506 Aug 13, 2024
26 checks passed
@mgovers mgovers deleted the feature/cmake-path-update branch August 13, 2024 10:14
@mgovers mgovers mentioned this pull request Nov 5, 2024
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement on internal implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants