Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use black-jupyter in pre-commit #700

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Conversation

nitbharambe
Copy link
Member

No description provided.

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add to the code quality CI check

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Copy link

@nitbharambe nitbharambe marked this pull request as ready for review August 22, 2024 07:29
@TonyXiang8787
Copy link
Member

Also add to dev requirement

@nitbharambe
Copy link
Member Author

nitbharambe commented Aug 22, 2024

Also add to dev requirement

@TonyXiang8787 Since black-jupyter is like a tool to aid in development and not essential, it would not count as dependency. We don't have black as a dev requirement either right now.
It is added to pre-commit configuration though.

@TonyXiang8787 TonyXiang8787 added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit 30881c9 Aug 23, 2024
26 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/black-jupyter-precommit branch August 23, 2024 09:10
@mgovers mgovers mentioned this pull request Nov 5, 2024
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants