Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix / Handle access violation to unconnected-regulated transformers #703

Merged
merged 6 commits into from
Aug 28, 2024
Merged

BugFix / Handle access violation to unconnected-regulated transformers #703

merged 6 commits into from
Aug 28, 2024

Conversation

Jerry-Jinfeng-Guo
Copy link
Contributor

This PR fixes #702

@Jerry-Jinfeng-Guo
added fix
46c9660 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo self-assigned this Aug 26, 2024
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the bug Something isn't working label Aug 26, 2024
@Jerry-Jinfeng-Guo
removed commented code; clang on Windows broken
7b69699 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
Copy link
Contributor Author

NB, clang on Windows is broken atm.

mgovers
mgovers reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the changes make sense to me. let's hope this fixes the issue

tests/cpp_unit_tests/test_tap_position_optimizer.cpp Outdated Show resolved Hide resolved
@Jerry-Jinfeng-Guo
added repro case to validation tests
5a0503c 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
mgovers
mgovers reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm investigating what causes clang-cl to fail

..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp Show resolved Hide resolved
mgovers and others added 2 commits August 28, 2024 09:25
@mgovers
move lambda out-of-line
18bc14c 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@Jerry-Jinfeng-Guo
one more safe guard at ranking level
b92d8f9 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo marked this pull request as ready for review August 28, 2024 07:56
mgovers
mgovers previously approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but i have one very small suggestion remaining

..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp Outdated Show resolved Hide resolved
@Jerry-Jinfeng-Guo
comment addressed
e9d1473 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
94.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit 4134bdb Aug 28, 2024
26 checks passed
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the bugfix/handle-isolated-nodes-accessing branch August 28, 2024 10:15
@petersalemink95 petersalemink95 mentioned this pull request Oct 9, 2024
Open
3 tasks
@Jerry-Jinfeng-Guo
Copy link
Contributor Author

This PR also fixes the validation of issue #662

@mgovers mgovers mentioned this pull request Nov 5, 2024
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitbharambe nitbharambe nitbharambe left review comments

@mgovers mgovers mgovers approved these changes

Assignees

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@Jerry-Jinfeng-Guo @mgovers @nitbharambe