Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Re route validation tests #718

Merged
merged 27 commits into from
Oct 7, 2024
Merged

Feature/Re route validation tests #718

merged 27 commits into from
Oct 7, 2024

Conversation

figueroa1395
Copy link
Contributor

@figueroa1395 figueroa1395 commented Sep 11, 2024 •
edited
Loading

Re-route the validation tests through the C API:

  • Move the call for the tests to the C++ wrapper of the C API.
  • Remove the PGM core dependencies.

Re-route the benchmarks through the C API:
- [ ] Move the call for the benchmark to the C++ wrapper of the C API.
- [ ] Remove the PGM core dependencies.

Note: The re-routing of the benchmark won't be addressed here anymore, since it requieres more effort than initially anticipated. For the moment, it is taken out of the CI build and addressed on the nightly build #736

Closes #486

@figueroa1395
Update error thrown
bf0ce79 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
[skip ci] working on single-validation - broken atm
380c421 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
[skip ci] fix func_selector
e63f13b 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@figueroa1395
[skip ci] working on single-validation - func_selector_broken
06fdf5b 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
[skip ci] debugging state - broken
23e76bc 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Merge branch 'main' into feature/re-route-benchmark-validation-tests
6e650c5
This was referenced Sep 24, 2024
Closed
Closed
@figueroa1395
[skip ci] fixed buffer deletion - broken: buffer overflow when parsing
963b7e9 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@TonyXiang8787
Copy link
Member

@figueroa1395 should the name of this PR be changed to only re-route validation tests?

@figueroa1395
Copy link
Contributor Author

@figueroa1395 should the name of this PR be changed to only re-route validation tests?

PR edited accordingly.

@figueroa1395
parse to buffer fixed
d8fbcbf 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@figueroa1395 figueroa1395 changed the title Feature/re route benchmark validation tests Feature/Re route validation tests Sep 26, 2024
@figueroa1395
Copy link
Contributor Author

Since I have started working on this PR again, this is very outdated at the moment. Many things have and will keep changing.

@figueroa1395
dataset creation working
f7deb31 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@figueroa1395
model.calculate working for all single-cases
66ffad5 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@figueroa1395
[skip ci] single tests compile - running broken
2a6cbd4 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@figueroa1395
[skip ci] fixed stack overflow - numeric problems now
b1f54a2 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@figueroa1395
[skip ci] single sym passes - asym broken
7230835 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@figueroa1395
[skip ci] asym fixed - new heap overflow issue
0c0633b 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@figueroa1395
single validation tests pass
98f1bfa 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Copy link
Contributor Author

At this stage all the single validation tests have been migrated to the Cpp API and pass. Next I will fix the batch validation.

@figueroa1395
full batch tests pass
dad4732 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@TonyXiang8787
Copy link
Member

@figueroa1395 you need to resolve merge conflict, otherwise the CI will not start.

@figueroa1395
Copy link
Contributor Author

@TonyXiang8787 Thanks, I did not know. I am doing a bit of refactoring and once I finish that, I will solve the conflict.

mgovers
mgovers reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great progress. will review the rest on monday when you're done cleaning up

tests/cpp_validation_tests/test_validation.cpp Outdated Show resolved Hide resolved
tests/cpp_validation_tests/test_validation.cpp Show resolved Hide resolved
tests/cpp_validation_tests/test_validation.cpp Outdated Show resolved Hide resolved
tests/cpp_validation_tests/test_validation.cpp Outdated Show resolved Hide resolved
tests/cpp_validation_tests/test_validation.cpp Show resolved Hide resolved
tests/cpp_validation_tests/test_validation.cpp Outdated Show resolved Hide resolved
tests/cpp_validation_tests/test_validation.cpp Outdated Show resolved Hide resolved
@figueroa1395
Merge branch 'main' into feature/re-route-benchmark-validation-tests
635b0f7
@figueroa1395
Addressed comments and sonar
6099e47 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Copy link
Contributor Author

The only things remaining at this point are doing a full manual clang tidy run and figuring out what is going on with the MacOS build.

@TonyXiang8787
fix aligned malloc bug
b3ca98f 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
Copy link
Member

TonyXiang8787 commented Oct 5, 2024 •
edited
Loading

The only things remaining at this point are doing a full manual clang tidy run and figuring out what is going on with the MacOS build.

@figueroa1395 @mgovers
After debugging in my Mac I have found the bug. The std::aligned_alloc has two requirements for unix-like system which we did not enforce:

  • Alignment should be multiple of sizeof(void*)
  • Size should be multiple of alignment

I have now pushed the fix.

@figueroa1395
Copy link
Contributor Author

@TonyXiang8787 Thanks! Great find and fix.

@figueroa1395
sonar
7c2d0bc 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@figueroa1395
clang tidy manual run
d1f29fd 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@figueroa1395 figueroa1395 marked this pull request as ready for review October 7, 2024 06:26
Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor comments.

mgovers
mgovers reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

halfway through the review. continuing now but then you can already process what i have so far

power_grid_model_c/power_grid_model_c/src/buffer.cpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model_c/src/buffer.cpp Show resolved Hide resolved
tests/cpp_validation_tests/test_validation.cpp Show resolved Hide resolved
tests/cpp_validation_tests/test_validation.cpp Show resolved Hide resolved
tests/cpp_validation_tests/test_validation.cpp Outdated Show resolved Hide resolved
tests/cpp_validation_tests/test_validation.cpp Outdated Show resolved Hide resolved
tests/cpp_validation_tests/test_validation.cpp Outdated Show resolved Hide resolved
@figueroa1395
Addressed comments and clang-tidy
e8f0c8b 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@figueroa1395 figueroa1395 mentioned this pull request Oct 7, 2024
Merged
TonyXiang8787
TonyXiang8787 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@TonyXiang8787 TonyXiang8787 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no open points and therefore approve the PR.

Feel free to put it in the merge queue.

@mgovers mgovers added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit dd0d1b0 Oct 7, 2024
28 checks passed
@mgovers mgovers deleted the feature/re-route-benchmark-validation-tests branch October 7, 2024 15:17
@mgovers mgovers mentioned this pull request Oct 8, 2024
Merged
2 tasks
@mgovers mgovers mentioned this pull request Nov 5, 2024
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgovers mgovers mgovers left review comments

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left review comments

@TonyXiang8787 TonyXiang8787 TonyXiang8787 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Optimize compilation speed by reorganize headers
4 participants
@figueroa1395 @TonyXiang8787 @Jerry-Jinfeng-Guo @mgovers