Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve C and CPP API target structure #741

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Improve C and CPP API target structure #741

merged 4 commits into from
Sep 26, 2024

Conversation

TonyXiang8787
Copy link
Member

Several improvements:

  • Headers are retrieved using glob.
  • C and CPP API both use FILE_SET.
  • Experimental macro define now in the CMakeLists.txt, with a TODO to remove them.
  • power_grid_model_cpp now depends on power_grid_model_c.
  • Package test also include a simple cpp header test on handle.

@TonyXiang8787
use glob for c api header
56739ad 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
use same file set for pgm_cpp
fcf4f46 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
test cpp wrapper in package test
9f57d20 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
fix experimental
920a9bd 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@mgovers mgovers enabled auto-merge September 26, 2024 11:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mgovers mgovers added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit 4a63339 Sep 26, 2024
26 checks passed
@mgovers mgovers deleted the fix/cmake-c-cpp-project branch September 26, 2024 13:29
@mgovers mgovers mentioned this pull request Nov 5, 2024
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgovers mgovers mgovers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TonyXiang8787 @mgovers