Feature/Improve batch columnar validation #751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
you can try multiple things:
|
figueroa1395
changed the base branch from
main
to
feature/columnar-dataset-python-extension
mgovers
reviewed
Oct 1, 2024
| @@ -80,7 +80,7 @@ def test_validate_batch_data_input_error(input_data, batch_data): | |||
|
|
|||
|
|
|||
| def test_validate_batch_data_update_error(input_data, batch_data): | |||
There was a problem hiding this comment.
can you add a validation case with columnar input and columnar update dataset?
Base automatically changed from
feature/columnar-dataset-python-extension
to
main
October 1, 2024 12:47
figueroa1395
changed the base branch from
main
to
feature/columnar-batch-list-support
|
Since #760 implemented some necessary changes for this PR and I have made a mess of myself, I will close this PR to open a new relevant one. |
|
@figueroa1395 please delete the branch if it is not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #734: Improves batch validation for columnar data.