Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Columnar data docs - native data interface serialization #788

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Columnar data docs - native data interface serialization #788

merged 6 commits into from
Oct 18, 2024

Conversation

nitbharambe
Copy link
Member

@nitbharambe nitbharambe commented Oct 16, 2024 •
edited
Loading

Partially covers issue: `#548

@nitbharambe
[skip ci] add native serialization docs
b6bc301 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe changed the title Columnar datadocumentation native data interface serialization Columnar data docs - native data interface serialization Oct 16, 2024
@nitbharambe nitbharambe marked this pull request as ready for review October 16, 2024 07:17
@nitbharambe @mgovers
Apply suggestions from code review
20c6a01 
Co-authored-by: Martijn Govers <martijn.govers@alliander.com>
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
@nitbharambe
address minor comments
05d726b 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
point out row and columnar data
0f27666 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
format code block
3560a1a 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
mgovers
mgovers previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nitpick but feel free to ignore it

docs/advanced_documentation/native-data-interface.md Outdated Show resolved Hide resolved
@nitbharambe @mgovers
Update docs/advanced_documentation/native-data-interface.md
0a03cba 
Co-authored-by: Martijn Govers <martijn.govers@alliander.com>
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nitbharambe nitbharambe self-assigned this Oct 18, 2024
@mgovers mgovers added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 33c184f Oct 18, 2024
26 checks passed
@mgovers mgovers deleted the docs/columnar-data-serialization-native branch October 18, 2024 12:35
@mgovers mgovers mentioned this pull request Nov 5, 2024
Closed
27 tasks
@figueroa1395 figueroa1395 mentioned this pull request Nov 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figueroa1395 figueroa1395 figueroa1395 left review comments

@mgovers mgovers mgovers approved these changes

Assignees

@nitbharambe nitbharambe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitbharambe @mgovers @figueroa1395