Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedstock is crashing after 1.9.72 on Mac OS. From the error log in the Azure pipelines, this can be traced back to #778, specifically to the
test_simple_permanent_update
test.In the test, a single permanent update was done via
model.update(update_data=update_batch)
, whereupdate_batch
was a many-scenario batch dataset, rather than a single scenario one, which is expected to work. However, due to the crash in the feedstock's CI, it was found that this functionality is not properly tested in the core.In this PR, the python test
test_simple_permanent_update
is changed to handle a single scenario permanent update to confirm this was the root of the issue and tests are added in the core to test the intended functionality.I expect two possible outcomes: