Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature / Update Python validation to support optional id in update data #793

Merged
merged 20 commits into from
Oct 28, 2024
Merged

Feature / Update Python validation to support optional id in update data #793

merged 20 commits into from
Oct 28, 2024

Conversation

Jerry-Jinfeng-Guo
Copy link
Contributor

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo commented Oct 17, 2024 •
edited
Loading

This PR updates the validation logic required for #771, which is the implementation of step 7 in issue #548

  • Revert the mark as fail
  • Update logic for checking
  • New unit test for valid_ids
    • uniform update
    • non-uniform update

@Jerry-Jinfeng-Guo
[skip ci] branch created
890837a 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the feature New feature or request label Oct 17, 2024
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo self-assigned this Oct 17, 2024
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the do-not-merge This should not be merged label Oct 18, 2024
@Jerry-Jinfeng-Guo
removed id_exists check and tests
3b0c6b6 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
Your code has been rated at 10.00/10, but I throw an error nonetheless
74e2225 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
isort has its own opinion
6bbd9a8 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Jerry-Jinfeng-Guo and others added 5 commits October 18, 2024 14:16
@Jerry-Jinfeng-Guo
Merge branch 'main' into feature/update-python-validation-to-support-…
9ea0f15 
…optional-id-input
@Jerry-Jinfeng-Guo
Merge branch 'main' into feature/update-python-validation-to-support-…
8fef79c 
…optional-id-input
@Jerry-Jinfeng-Guo
New check logic
56cae49 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
explicit optional
4880c91 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
unit test added; next to columnar input
c71493a 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@mgovers mgovers mentioned this pull request Oct 23, 2024
Closed
27 tasks
Jerry-Jinfeng-Guo and others added 4 commits October 23, 2024 13:11
@Jerry-Jinfeng-Guo
Merge branch 'main' into feature/update-python-validation-to-support-…
b783aef 
…optional-id-input
@Jerry-Jinfeng-Guo
extended unit test for validate ids
f775c2b 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
lambda to functions
5e33695 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
address linter complain
4f0fce4 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo marked this pull request as ready for review October 24, 2024 05:44
@Jerry-Jinfeng-Guo
thou shall not pass; linter 2.0
e57b446 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
there is his-py and mypy
4761123 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
figueroa1395
figueroa1395 reviewed Oct 24, 2024
View reviewed changes
src/power_grid_model/_utils.py Show resolved Hide resolved
src/power_grid_model/_utils.py Show resolved Hide resolved
src/power_grid_model/_utils.py Outdated Show resolved Hide resolved
src/power_grid_model/_utils.py Outdated Show resolved Hide resolved
src/power_grid_model/validation/errors.py Show resolved Hide resolved
tests/unit/validation/test_validation_functions.py Show resolved Hide resolved
tests/unit/validation/test_validation_functions.py Show resolved Hide resolved
Jerry-Jinfeng-Guo and others added 4 commits October 25, 2024 10:03
@Jerry-Jinfeng-Guo
addressed comment
a43a365 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
format
ac8082d 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
revert ComponentData
2c08abd 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@nitbharambe
fix last test
0fd17d0 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
figueroa1395
figueroa1395 previously approved these changes Oct 25, 2024
View reviewed changes
@nitbharambe nitbharambe added this pull request to the merge queue Oct 28, 2024
@figueroa1395 figueroa1395 removed this pull request from the merge queue due to a manual request Oct 28, 2024
@figueroa1395
Copy link
Contributor

@nitbharambe The PR is marked as do not merge.

@nitbharambe
change to get comp size
ad11736 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo changed the base branch from main to feature/columnar-data-support-no-id-field October 28, 2024 12:35
@TonyXiang8787 TonyXiang8787 removed the do-not-merge This should not be merged label Oct 28, 2024
@TonyXiang8787 TonyXiang8787 merged commit 1ccd250 into feature/columnar-data-support-no-id-field Oct 28, 2024
26 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/update-python-validation-to-support-optional-id-input branch October 28, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitbharambe nitbharambe nitbharambe left review comments

@mgovers mgovers mgovers left review comments

@figueroa1395 figueroa1395 figueroa1395 approved these changes

Assignees

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jerry-Jinfeng-Guo @figueroa1395 @mgovers @nitbharambe @TonyXiang8787