Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG in test / Memory access violation in update test #810

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

Jerry-Jinfeng-Guo
Copy link
Contributor

This is the repro case for the AddressSanitizer issue on Linux/WSL/gcc13. Source of bug is in main_model_impl.hpp, where the update data is querried as a buffer span.

The root cause of the bug is the fact that the API model is not correctly and thoroughly tested. This is exemplified by #795.

Further, this bug is believed to be closely related to #802

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the bug Something isn't working label Oct 27, 2024
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Jerry-Jinfeng-Guo and others added 2 commits October 28, 2024 10:10
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
Copy link

@TonyXiang8787 TonyXiang8787 added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit d504b55 Oct 28, 2024
26 checks passed
@TonyXiang8787 TonyXiang8787 deleted the bug/AddressSanitizer-issue-bug-re-pro-case branch October 28, 2024 11:29
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo changed the title BUG / Memory access violation in buffer span of update data BUG in test / Memory access violation in update test Oct 29, 2024
@mgovers mgovers mentioned this pull request Nov 5, 2024
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants