Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove compatibility convert for output #821

Merged
merged 7 commits into from
Nov 7, 2024
Merged

Remove compatibility convert for output #821

merged 7 commits into from
Nov 7, 2024

Conversation

nitbharambe
Copy link
Member

No description provided.

@nitbharambe
wip added tests
761a22a 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add batch tests
3c36d08 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
resolve mypy
8e13aeb 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe marked this pull request as ready for review November 7, 2024 07:22
@nitbharambe
remove unused import
2e57560 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
move imports
79f556f 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
figueroa1395
figueroa1395 reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I just have very minor comments. Also, nice testing.

tests/unit/test_data_handling.py Show resolved Hide resolved
tests/unit/test_data_handling.py Outdated Show resolved Hide resolved
tests/unit/test_data_handling.py Outdated Show resolved Hide resolved
tests/unit/test_data_handling.py Outdated Show resolved Hide resolved
tests/unit/test_data_handling.py Show resolved Hide resolved
mgovers
mgovers reviewed Nov 7, 2024
View reviewed changes
src/power_grid_model/core/data_handling.py Outdated Show resolved Hide resolved
tests/unit/test_data_handling.py Outdated Show resolved Hide resolved
tests/unit/test_data_handling.py Outdated Show resolved Hide resolved
tests/unit/test_data_handling.py Outdated Show resolved Hide resolved
@nitbharambe
address comments
7bfad01 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add docstring to sc
1cceb64 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@mgovers mgovers enabled auto-merge November 7, 2024 13:14
@figueroa1395 figueroa1395 mentioned this pull request Nov 7, 2024
Closed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mgovers mgovers added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 0e39f47 Nov 7, 2024
26 checks passed
@mgovers mgovers deleted the feature/activate-columnar-output branch November 7, 2024 14:35
@mgovers mgovers mentioned this pull request Nov 11, 2024
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figueroa1395 figueroa1395 figueroa1395 left review comments

@mgovers mgovers mgovers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitbharambe @mgovers @figueroa1395