Skip to content

Conversation

@petersalemink95
Copy link
Member

@petersalemink95 petersalemink95 commented Jan 27, 2025

Validation test for #885

Test is a copy of auto-tap-changer-meshed-any, with adjusted u_band for transformer regulators in the second rank -> u_band too small to find a solution.

petersalemink95 and others added 3 commits January 27, 2025 16:04
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
petersalemink95 and others added 9 commits January 27, 2025 17:26
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
fix for infinite loop in automatic tap changer
@petersalemink95 petersalemink95 marked this pull request as ready for review January 28, 2025 09:49
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved all comments with latest input + reviewed once more. LGTM. Glad we found this

@mgovers mgovers enabled auto-merge January 28, 2025 09:51
@sonarqubecloud
Copy link

@mgovers mgovers added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 9215351 Jan 28, 2025
28 checks passed
@mgovers mgovers deleted the test/auto-tap-test branch January 28, 2025 10:27
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the improvement Improvement on internal implementation label May 13, 2025
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo changed the title validation test for automatic tap Validation test for automatic tap infinite loop fix May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement on internal implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants