-
Notifications
You must be signed in to change notification settings - Fork 5
Added new user and device allocation functionality #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ignore to include the new file
…ices.json and update requirements.txt with new dependencies
…nd update devices accordingly; modify add_user endpoint to accept JSON payload
…and connection tests
david-g-f
approved these changes
Mar 11, 2025
Contributor
david-g-f
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several significant updates to the backend and frontend of the application, focusing on device allocation functionality, error handling, and user management. The most important changes include the addition of new functions for device allocation, updates to existing functions to handle the new allocation logic, and the introduction of a new frontend component for device allocation.
Backend Changes
Device Allocation Logic:
allocate_devicesfunction inbackend/users.pyto allocate devices to a user based on their User ID.backend/devices_json.pyto create and manageselected_user_devices.jsonbased on the allocated devices of the selected user.Function Updates:
loadJSONto load user and device data and filter allocated devices.changeDeviceStatus,updateDevices, andchangeConnectionto use the newloadDevicesJSONfunction. [1] [2]API Enhancements:
/allocate_devicesinbackend/fastAPI.pyto handle device allocation requests.Configuration and Dependencies:
.gitignoreto includeselected_user_devices.json.requirements.txtto include new dependencies such asexceptiongroupandPyYAML.Frontend Changes
AllocateDevicesDialogcomponent infrontend/src/app/ui/allocateDevices.jsxto provide a UI for allocating devices to users.frontend/src/app/ui/dashboard/accountMenu.jsx. [1] [2]Testing Updates
backend/tests/test_devices_json.pyto focus on the new allocation logic. [1] [2] [3]