-
Notifications
You must be signed in to change notification settings - Fork 5
Completed Automations #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-g-f
approved these changes
Mar 15, 2025
Contributor
david-g-f
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the backend automation and device management system. The updates include refactoring existing functions, adding new automation functionalities, and cleaning up debug print statements.
Automation Enhancements:
backend/automations.json: Updated the structure to include multiple automation entries with specific attributes such asid,name,device_id,triggers, andstatus.backend/automations.py: Added functions to load, update, add, delete, and edit automation rules, and implemented an asynchronous scheduler to trigger automations at specified times.Device Management Improvements:
backend/devices_json.py: Removed unused functions related to device timers, cleaned up debug print statements, and updated functions to handle device status changes more efficiently. [1] [2] [3] [4] [5]API Enhancements:
backend/fastAPI.py: Integrated new automation functions into the FastAPI endpoints, added new endpoints for managing automations, and cleaned up imports and middleware setup. [1] [2] [3] [4] [5] [6]Testing Updates:
backend/tests/test_devices_json.py: Commented out tests related to the removed timer functionality.