fix: sign bug & revert onTouch #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 18, 2023 16:09
CoolLoong
requested review from
SuperIceCN and
smartcmd
and removed request for
SuperIceCN
SuperIceCN
approved these changes
Jun 18, 2023
| @@ -364,4 +367,14 @@ private static void sanitizeText(String[] lines) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| private static String joinNotNull(String delim, String... elements) { | |||
There was a problem hiding this comment.
这个可以放到cn.nukkit.utils.StringUtils里面，也可以用Arrays.stream一行解决
| @@ -526,7 +526,7 @@ private void handleUseItem(@NotNull PlayerHandle playerHandle, @NotNull Inventor | |||
| boolean spamBug = (playerHandle.getLastRightClickPos() != null && System.currentTimeMillis() - playerHandle.getLastRightClickTime() < 100.0 && blockVector.distanceSquared(playerHandle.getLastRightClickPos()) < 0.00001); | |||
| playerHandle.setLastRightClickPos(blockVector.asVector3()); | |||
| playerHandle.setLastRightClickTime(System.currentTimeMillis()); | |||
| if (spamBug && player.getInventory().getItemInHand().getBlockId() == BlockID.AIR) { | |||
There was a problem hiding this comment.
物品在告示牌上使用会触发多次，我不理解这里为什么一定只存在于空气物品
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.