Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redstone OPT #996

Merged
merged 37 commits into from
Feb 6, 2023
Merged

Redstone OPT #996

merged 37 commits into from
Feb 6, 2023

Conversation

smartcmd
Copy link
Member

@smartcmd smartcmd commented Feb 3, 2023 •
edited
Loading

@smartcmd smartcmd marked this pull request as draft February 3, 2023 12:02
@smartcmd smartcmd changed the title Piston OPT Redstone OPT Feb 4, 2023
@smartcmd smartcmd marked this pull request as ready for review February 5, 2023 18:47
@smartcmd smartcmd requested review from CoolLoong and SuperIceCN and removed request for CoolLoong February 5, 2023 18:47
@smartcmd
Copy link
Member Author

smartcmd commented Feb 5, 2023

Minecraft.2023.02.06.-.03.23.33.13.mp4

@smartcmd
Copy link
Member Author

smartcmd commented Feb 5, 2023

Minecraft.2023.02.06.-.04.38.13.17.mp4

@CoolLoong
Copy link
Member

合并一下主分支

@smartcmd
Copy link
Member Author

smartcmd commented Feb 6, 2023

合并一下主分支

不用了，待会就合并了

CoolLoong
CoolLoong approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@CoolLoong CoolLoong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有看红石逻辑，不过玩了这么久应该没啥大问题。

src/main/java/cn/nukkit/block/BlockChest.java
/**
* 大箱子在PNX不能推动
*/
protected boolean canMove() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以添加一个todo等未来解决吗，bds会将大箱子拆分成小箱子推出去

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

src/main/java/cn/nukkit/block/BlockChorusFlower.java
this.getLevel().useBreakOn(this);
projectile.kill();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

能解释一下为什么移除这一行吗

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在EntityProjectile那边有对应的kill逻辑，这边多余了

SuperIceCN
SuperIceCN approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@SuperIceCN SuperIceCN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我能力之内看不出问题，很多部分超出我确认没有问题的能力，我选择相信刀哥

@smartcmd smartcmd merged commit 90dfc65 into master Feb 6, 2023
@CoolLoong CoolLoong deleted the feature/ec-piston branch February 15, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoolLoong CoolLoong CoolLoong approved these changes

@SuperIceCN SuperIceCN SuperIceCN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

活塞bug
3 participants
@smartcmd @CoolLoong @SuperIceCN