OCGV - Fixes OutputMode Single #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Tyler James Leonhardt <tylerl0706@gmail.com>
This was referenced Sep 27, 2020
|
I see a couple changes from the other PR. Can you rebase? |
| @@ -27,7 +27,7 @@ public HashSet<int> Start(ApplicationData applicationData) | |||
| _applicationData = applicationData; | |||
| _gridViewDetails = new GridViewDetails | |||
| { | |||
| // If we have an OutputMode, then we want to make them selectable. If we make them selectable, | |||
| // If OutputMode is Multiple, then we make items selectable. If we make them selectable, | |||
| // they have a 8 character addition of a checkbox (" [ ]") that we have to factor in. | |||
| ListViewOffset = _applicationData.OutputMode != OutputModeOption.None ? 8 : 4 | |||
There was a problem hiding this comment.
don't you need to change this?
There was a problem hiding this comment.
The spacing is correct for both Single and Multiple modes now (we are now using Terminal.Gui's AllowsMultipleSelection feature.
the comment is not quite right. I'll fix it.
|
I don't know why anyone would use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #23 and #79 for
ocgv. It is dependent on PR #106.Previously
-OutputMode Singleworked exactly like-OutputMode Multiplewhich was a bug. With this PR all three modes (None,Single, andMultiple) work correctly:None - No marking of items is possible. ENTER does nothing. ESC cancels.
Single - No marking of multiple items is possible. Single selection 'mark UI' is shown. SPACE selects a single item. NTER selects the selected item and it is returned. ESC cancels.
Multiple - Marking of multiple items is possible with Multiple selection 'mark UI' using SPACE. ENTER returns selected items. ESC cancels.
Closes: Out-ConsoleGridView -OutputMode Single - cannot select anything #79