Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighter columns & less rows #115

Merged
merged 31 commits into from
Oct 3, 2020
Merged

Conversation

tig
Copy link
Collaborator

@tig tig commented Sep 29, 2020

This PR improves usage of scarce screen real estate by

  • Removing excess padding around the list
  • Removing excess padding between check/select UI and first column
  • Removing excess padding at bottom of list

image

It also prepares for an upcoming change to Terminal.Gui that will change the clunky 3 character check/select UI ([x]) to single char glyphs ();

tig and others added 26 commits March 11, 2020 15:55
Co-Authored-By: Tyler James Leonhardt <tylerl0706@gmail.com>
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you need me to test this again to make sure the checkbox wasn't blank?

Build.ps1 Outdated
@@ -1,3 +1,3 @@
Invoke-Build Build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly if you wanna have this just build ConsoleGuiTools for now that's probably fine since Graphical Tools is waiting on MAUI

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Builds take toooo loooong.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should I change to make this so?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TylerLeonhardt I am struggling figuring out how to change the build scripts to build only CGT. Can you give me a hint por-favor?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TylerLeonhardt Nevermind - figured it out:

param(
    [ValidateSet("Debug", "Release")]
    [string]$Configuration = "Debug",

    [string[]]$ModuleName = @( 
        #"Microsoft.PowerShell.GraphicalTools", 
        "Microsoft.PowerShell.ConsoleGuiTools" ) 
)

Although, to do this right, it would be nice to have the GraphicalTools.build.ps1 take a parameter [Gui|ConoleGui|Both] such that Build.ps1 could do this:

Invoke-Build Build ConsoleGui

But I'm not savvy enough on PS yet to put the logic into the param statement above.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind again - I'm now savvy enough. ;-) see latest commit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And FWIW, my changes do not impact the CI/CD builds. Both modules are still being built there, which seems right minded.

@TylerLeonhardt
Copy link
Member

oh I see "prepare" got it

Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, otherwise looks good. If trying to make efficient use of screen real estate, should we replace ... with (should be separate PR anyways)

@TylerLeonhardt
Copy link
Member

didn't we try the ... but gui.cs didn't support that character or something?

@tig
Copy link
Collaborator Author

tig commented Sep 30, 2020

Unfortunately … is one of those Unicode chars that spans two columns. Which is hard on consoles, and not supported in gui.cs yet.

Fill(1) means "leave one row margin on right".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants