Fixed #58 - Newlines in commands render incorrectly #60
Conversation
| // Replace any newlines with encoded newline (`n) | ||
| // Note we can't use Environment.Newline because we don't know that the | ||
| // Command honors that. | ||
| strings[i] = strings[i].Replace("\n", "`n"); |
There was a problem hiding this comment.
So thinking about this some more, it may be possible that the string has a carriage return and a linefeed. So in addition to what you're doing here, we should also handle that so:
| strings[i] = strings[i].Replace("\n", "`n"); | |
| strings[i] = strings[i].Replace("\r\n", "`r`n"); | |
| strings[i] = strings[i].Replace("\n", "`n"); |
This makes sure there are no lingering \r.
There was a problem hiding this comment.
Would it be just as good to do a replace for \r and another for \n and thus catch all of them by default?
There was a problem hiding this comment.
Yeah that's true. I guess that would catch the off chance that there's a \r by itself.
There was a problem hiding this comment.
I concur. I've changed it to:
// Replace any newlines with encoded newline/linefeed (`n or `r)
// Note we can't use Environment.Newline because we don't know that the
// Command honors that.
strings[i] = strings[i].Replace("\r", "`r");
strings[i] = strings[i].Replace("\n", "`n");I don't do many PRs, so I'm not sure what I'm supposed to do to push this through other than pushing it to my master branch... I think it's automatic?
There was a problem hiding this comment.
You should create new branch for every new PR.
Co-Authored-By: Tyler James Leonhardt <tylerl0706@gmail.com>
|
I'll give @SteveL-MSFT a chance to review since I won't be snapping a new release til probably Friday/Monday. |
| @@ -88,6 +88,35 @@ Get-Process | Out-ConsoleGridView | |||
| > NOTE: If you change the code and rebuild the project, you'll need to launch a | |||
| > _new_ PowerShell process since the dll is already loaded and can't be unloaded. | |||
|
|
|||
| ### Debugging in Visual Studio Code | |||
There was a problem hiding this comment.
Thank you so much for this!!
@tig by pushing to the branch for the PR it will automatically update the PR. A general recommendation is to create a branch for the PR and push to that branch. This allows you to keep master up to date with the upstream repository without causing issues with your PR (it also appears to be fairly common for the first few PRs to do them from master because it's not known how else to do it). |
Yep. I now get it. Appreciate the help. |
Per #58