-
Notifications
You must be signed in to change notification settings - Fork 56
update sshd config grammar #1281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR makes the quotedString grammar node visible in the parse tree by removing the underscore prefix from _quotedString to quotedString. This change enables proper differentiation between regular strings and quoted strings when parsing space-separated arguments in SSH server configuration files (e.g., allowgroups admins devs "openssh users").
- Updated grammar rule from hidden
_quotedStringto visiblequotedString - Updated all test expectations to include the
quotedStringnode in parse trees
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| grammars/tree-sitter-ssh-server-config/grammar.js | Changed _quotedString to quotedString in both the rule definition and the arguments choice, making the node visible in the parse tree |
| grammars/tree-sitter-ssh-server-config/test/corpus/valid_expressions.txt | Updated 6 test cases to expect quotedString nodes wrapping string nodes in the parse tree output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PR Summary
Matchcriteria