(MAINT) Fix the registry find command options
#163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the `registry find` command panicked because the `key_path` and
`keys_only` options both declared the default short form for the options. Clap resolved
both options to short form `-k`, leading to a conflict and panic.
This change removes the short form for the `--keys_only` and `--values_only` options,
removing the conflict so the command doesn't panic.
The new options from `registry find --help` display as:
```console
Find a registry key or value.
Usage: registry.exe find [OPTIONS] --key-path <KEY_PATH> --find <FIND>
Options:
-k, --key-path <KEY_PATH> The registry key path to start find.
-f, --find <FIND> The string to find.
-r, --recurse Recursively find.
--keys-only Only find keys.
--values-only Only find values.
-h, --help Print help
```
SteveL-MSFT
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This change removes the short form for the
--keys_onlyand--values_onlyoptions, removing the conflict so the command doesn't panic.The new options from
registry find --helpdisplay as:PR Context
Prior to this change, the
registry findcommand panicked because thekey_pathandkeys_onlyoptions both declared the default short form for the options. Clap resolved both options to short form-k, leading to a conflict and panic.