Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminate process tree on ctrl+c #213
Terminate process tree on ctrl+c #213
Changes from all commits
4bb61b8
381ffbe
1a7d315
bdb42dc
4e16ed7
77267f9
bd2cf0a
d5502be
f43f57d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this change/implementation from the user-facing perspective and the schema - it moves the schema from a set of enum values (in JSON Schema syntax) to a
oneOf
that is more complicated and harder for users to adjust/grok.I would propose an enum value like
ReplaceArg
(replaceArg
in the JSON) that always replaces a static string argument in the list, instead of allowing an arbitrary string.We could have that argument be something like
{{instance_json}}
to be very unlikely to conflict with any actual arguments.Then the manifest would look like:
From a schema perspective, we can then validate that when
input
isreplaceArg
thatargs
includes the static string and not wheninput
is any other value.Are there cases where users will need to specify a custom value for the replacement string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaeltlombardi please open a new issue to discuss