New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the build for tree-sitter parser #229

Merged

SteveL-MSFT merged 1 commit into PowerShell:main from daxian-dbw:parser

Oct 11, 2023

Member

daxian-dbw commented Oct 11, 2023 •

edited

Loading

PR Summary

Simplify the build for tree-sitter parser. There seems to be no need to run node-gyp configure and node-gyp build.

The bindings and src folders are generated by tree-sitter generate
tree-sitter test will build the generated C file using the node module nan, and run tests using node.

With this change, there will be much less node modules installed to the local node_modules folder, which will make the CIs slightly faster.


          Simplify the build for tree-sitter parser

8f3f21f

daxian-dbw marked this pull request as ready for review

October 11, 2023 22:45

SteveL-MSFT approved these changes

View reviewed changes

SteveL-MSFT added this pull request to the merge queue

Merged via the queue into PowerShell:main with commit 4835145

daxian-dbw deleted the parser branch

October 11, 2023 22:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet