Enable group resource output schema to simplify config output that uses groups #318
Conversation
SteveL-MSFT
force-pushed
the
config-result
branch
from
fd6ce62
to
9fb3058
Compare
| type: Test/Echo | ||
| properties: | ||
| output: Last | ||
| dependsOn: |
There was a problem hiding this comment.
seems like too short ident for dependsOn.
There was a problem hiding this comment.
This dependsOn is for the Last Group whereas the lines above are the resources within the group, so the indent here is correct
| @@ -7,14 +7,17 @@ | |||
| "executable": "dsc", | |||
| "args": [ | |||
| "config", | |||
| "test" | |||
| "--as-group", | |||
There was a problem hiding this comment.
It would help if there were short examples of format for both --as-group and --as-get in PR description (and docs).
There was a problem hiding this comment.
I provided descriptions of those two switches in the PR description. They won't be doc'd since they are hidden and intended to be only used by dsc itself.
| @@ -102,6 +147,27 @@ pub struct ResourceTestResult { | |||
| pub result: TestResult, | |||
| } | |||
|
|
|||
| #[derive(Debug, Clone, PartialEq, Deserialize, Serialize, JsonSchema)] | |||
| #[serde(deny_unknown_fields)] | |||
There was a problem hiding this comment.
Is there a strong reason to deny_unknown_fields ?
There was a problem hiding this comment.
We can evaluate if we want to allow arbitrary fields later if a scenario comes up
PR Summary
get,set, andtestdscas a resource has new--as-groupto use this new schemadscas a resource has new--as-getto use with AssertionGroup so that atestoperation still returns agetoutput to conform with new schemavalidatemethod for group resources instead of relying only on schemadscwas the resource)osinforeadme to match codePR Context
Addresses the
getpart of #266,setandtestwill be addressed in separate PRs